Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]Support helm chart propagation #1881

Closed
wants to merge 4 commits into from

Conversation

Poor12
Copy link
Member

@Poor12 Poor12 commented May 25, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support helm chart propagation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 25, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 25, 2022
@Poor12 Poor12 force-pushed the test-04 branch 7 times, most recently from 004ea95 to 03d25ad Compare May 26, 2022 02:39
Poor12 added 2 commits May 26, 2022 10:55
Signed-off-by: Poor12 <shentiecheng@huawei.com>
Signed-off-by: Poor12 <shentiecheng@huawei.com>
@Poor12 Poor12 force-pushed the test-04 branch 3 times, most recently from 0fb8891 to 7a8f82d Compare May 26, 2022 07:54
Signed-off-by: Poor12 <shentiecheng@huawei.com>
@Poor12 Poor12 force-pushed the test-04 branch 5 times, most recently from 963f467 to e500048 Compare May 27, 2022 01:23
@Poor12 Poor12 changed the title [WIP][feature]Support helm chart propagation [feature]Support helm chart propagation May 27, 2022
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2022
Signed-off-by: Poor12 <shentiecheng@huawei.com>
@@ -115,6 +115,7 @@ func RenderOpenAPISpec(cfg Config) (string, error) {
}

// Create Swagger Spec.
//nolint:staticcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem here?

@Poor12 Poor12 closed this May 30, 2022
@Poor12 Poor12 deleted the test-04 branch July 1, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants