Add cluster success threshold #1884
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/M
| threshold = c.failureThreshold | ||
| } | ||
|
|
||
| if isConditionTrue(observedReadyCondition) != isConditionTrue(curReadyCondition) && |
There was a problem hiding this comment.
| if isConditionTrue(observedReadyCondition) != isConditionTrue(curReadyCondition) && | |
| if observedReadyCondition != curReadyCondition && |
I can't see what's the difference between this, and the unit test seems ok with the change I'm suggesting.
There was a problem hiding this comment.
Because the condition can be True/False/Unknown, here we should only distinguish "true" and "not true" I think
For example, if the condition is changed from False to Unknown, we should update to Unknown immediately rather than retaining False
There was a problem hiding this comment.
For example, if the condition is changed from False to Unknown,
The condition should never change from true/false to unknown. Any other examples?
[edit]: Ignore the comments.
|
@dddddai For a similar idea, I also post at #1945 (comment). |
Not really, we can't tell when the "observed" cluster status changed through |
Give an example? |
Signed-off-by: dddddai <dddwq@foxmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Cluster success threshold is the duration of successes for the cluster to be considered healthy after recovery.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We should be careful about the default value as it could slow down the cluster recovery, personally I'd prefer set the default value to 0 for keeping user experience as before, if users do need this threshold, they could set it.
Does this PR introduce a user-facing change?: