Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Improve docs/working-with-anp.md #2040

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

windsonsea
Copy link
Member

Signed-off-by: windsonsea haifeng.yao@daocloud.io

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Remove some minor errors about grammar

Which issue(s) this PR fixes:
Fix text errors

Special notes for your reviewer:
CC @Arhell @rgrupesh , thanks.

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 21, 2022
@karmada-bot
Copy link
Collaborator

Welcome @windsonsea! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 21, 2022
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@windsonsea Thanks!

Looks good to me.

@XiShanYongYe-Chang
Copy link
Member

/cc @Tingtal @RainbowMango

@Tingtal
Copy link
Contributor

Tingtal commented Jul 1, 2022

/cc @Tingtal @RainbowMango

Looks good to me too.

Copy link
Member

@rgrupesh rgrupesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@windsonsea windsonsea changed the title [doc] some text changes to make desc more clear [doc] Improve docs/working-with-anp.md Jul 1, 2022
@RainbowMango
Copy link
Member

/lgtm
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2022
@karmada-bot karmada-bot merged commit 67996bb into karmada-io:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants