-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Improve docs/working-with-anp.md #2040
Conversation
Welcome @windsonsea! It looks like this is your first PR to karmada-io/karmada 🎉 |
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@windsonsea Thanks!
Looks good to me.
Looks good to me too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: windsonsea haifeng.yao@daocloud.io
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Remove some minor errors about grammar
Which issue(s) this PR fixes:
Fix text errors
Special notes for your reviewer:
CC @Arhell @rgrupesh , thanks.
Does this PR introduce a user-facing change?:
NONE