Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync status of pvc #2070

Merged
merged 1 commit into from
Jul 1, 2022
Merged

sync status of pvc #2070

merged 1 commit into from
Jul 1, 2022

Conversation

chaunceyjiang
Copy link
Member

Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
PVC used frequently. I think that build-in interpreter aggregatestatus should contain PVC

Which issue(s) this PR fixes:
Fixes #2065

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`:  `interpreter framework` start to support PVC status aggregation.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 28, 2022
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2022
@chaunceyjiang
Copy link
Member Author

image

@RainbowMango
Copy link
Member

/assign @XiShanYongYe-Chang

@chaunceyjiang
Copy link
Member Author

https://github.com/chaunceyjiang/karmada/actions/runs/2573428844
image

我感觉 karmada仓库 的github action 是不是有问题呀，好几次我的仓库的e2e是可以过的，一旦到karmada仓库下就不行了

@XiShanYongYe-Chang
Copy link
Member

Should be fixed with #2072

@chaunceyjiang
Copy link
Member Author

/cc @XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

/cc @XiShanYongYe-Chang

ok

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chaunceyjiang, I just ask a question, I have no actual application scenario, so I am not sure which fields of status need to be collected. Do you think other fields(such as capacity, conditions, etc.) need to be considered?

@chaunceyjiang
Copy link
Member Author

In my scenario, I only care about status, and I don't care about other fields. If other users care about other fields, they can add them later.

@chaunceyjiang chaunceyjiang force-pushed the aggregate_status_pvc branch 2 times, most recently from cd3b7c0 to b9cd77f Compare June 29, 2022 08:23
@XiShanYongYe-Chang
Copy link
Member

/assign @Garrybest

@chaunceyjiang chaunceyjiang force-pushed the aggregate_status_pvc branch 3 times, most recently from 3a9d358 to 27c8a09 Compare June 29, 2022 10:18
@chaunceyjiang
Copy link
Member Author

/cc @Garrybest

@Garrybest
Copy link
Member

Thanks!
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

/cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@RainbowMango
Copy link
Member

We need to update the documents, isn't it? @XiShanYongYe-Chang
https://github.com/karmada-io/karmada/blob/master/docs/userguide/customizing-resource-interpreter.md#aggregatestatus

@XiShanYongYe-Chang
Copy link
Member

We need to update the documents, isn't it?

Yes, it is.

Hi @chaunceyjiang, can you help update the document?

@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@chaunceyjiang
Copy link
Member Author

We need to update the documents, isn't it?

Yes, it is.

Hi @chaunceyjiang, can you help update the document?

Done

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick response.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@XiShanYongYe-Chang
Copy link
Member

Hi @chaunceyjiang, have you rebase the master branch?

@chaunceyjiang
Copy link
Member Author

chaunceyjiang commented Jul 1, 2022 •
edited
Loading

Should be fixed with #2072

If you want to ask whether includes your #2072, the answer is yes

@XiShanYongYe-Chang
Copy link
Member

What I mean is #2095.

@chaunceyjiang
sync status of pvc
6ffe6f0 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@chaunceyjiang
Copy link
Member Author

chaunceyjiang commented Jul 1, 2022 •
edited
Loading

What I mean is #2095.

Done!

karmada/go.mod

Line 42 in 9834e64

sigs.k8s.io/kind v0.12.0

Does this need to be upgraded?

@XiShanYongYe-Chang
Copy link
Member

Does this need to be upgraded?

Thanks for your mind, it does need to be upgraded.

@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
RainbowMango
RainbowMango approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@karmada-bot karmada-bot merged commit 81097a4 into karmada-io:master Jul 1, 2022
@RainbowMango RainbowMango added this to the v1.3 milestone Aug 30, 2022
@chaunceyjiang chaunceyjiang deleted the aggregate_status_pvc branch September 1, 2022 01:20
@RainbowMango RainbowMango mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

Assignees

@RainbowMango RainbowMango

@Garrybest Garrybest

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Why does Built-in Interpreter AggregateStatus not contain PVC
5 participants
@chaunceyjiang @RainbowMango @XiShanYongYe-Chang @Garrybest @karmada-bot