-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix]Return err when create resource failed #2074
[bugfix]Return err when create resource failed #2074
Conversation
Signed-off-by: changzhen <changzhen5@huawei.com>
/lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @duanmengkk |
/lgtm |
@duanmengkk, It's okay. I missed it when I reviewed it. |
/hold cancel Thanks @duanmengkk for your quick response. |
Signed-off-by: changzhen changzhen5@huawei.com
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
When create failed we need to return error in
objectwatcher.go
.Which issue(s) this PR fixes:
Fixes #2072
Special notes for your reviewer:
Does this PR introduce a user-facing change?: