Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add karmadactl addons subcommand #2134

Merged
merged 1 commit into from Aug 2, 2022
Merged

Add karmadactl addons subcommand #2134

merged 1 commit into from Aug 2, 2022

Conversation

wuyingjun-lucky
Copy link
Member

@wuyingjun-lucky wuyingjun-lucky commented Jul 5, 2022 •
edited

Co-authored-by: duanmeng duanmeng_yewu@cmss.chinamobile.com
Signed-off-by: wuyingjun wuyingjun_yewu@cmss.chinamobile.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add karmadactl addons subcommand
Which issue(s) this PR fixes:
Fixes #1957

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 5, 2022
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 5, 2022
@wuyingjun-lucky wuyingjun-lucky changed the title Add karmadactl addons subcommand [WIP]Add karmadactl addons subcommand Jul 5, 2022
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022
@wuyingjun-lucky wuyingjun-lucky force-pushed the karmada_addon branch 6 times, most recently from fbadec6 to dfc947e Compare July 6, 2022 05:34
@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented Jul 6, 2022 •
edited

-------------------------------------------------latest test result-------------------------------------------------

image
image
image
image

@wuyingjun-lucky wuyingjun-lucky changed the title [WIP]Add karmadactl addons subcommand Add karmadactl addons subcommand Jul 6, 2022
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2022
@wuyingjun-lucky
Copy link
Member Author

/assign @lonelyCZ
/assign @prodanlabs

@lonelyCZ
Copy link
Member

lonelyCZ commented Jul 8, 2022

Thanks for your hard work. I will review it ASAP.

lonelyCZ
lonelyCZ reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@lonelyCZ lonelyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions! @wuyingjun-lucky @duanmengkk

I just tested it that was very cool. I think we can start to review it, this is fisrt round.

pkg/karmadactl/addons/addons.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/init/addon.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/list.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/list.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/init/list_option.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/init/enable_option.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/init/enable_option.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/init/enable_option.go Outdated Show resolved Hide resolved
pkg/karmadactl/addons/estimator/estimator.go Outdated Show resolved Hide resolved
lonelyCZ
lonelyCZ reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@lonelyCZ lonelyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions! @wuyingjun-lucky @duanmengkk

I just tested it that was very cool. I think we can start to review it, this is fisrt round.

@wuyingjun-lucky wuyingjun-lucky force-pushed the karmada_addon branch 7 times, most recently from 8cfcf2d to c429520 Compare July 24, 2022 14:14
@wuyingjun-lucky
Copy link
Member Author

/assign @RainbowMango

@wuyingjun-lucky
Copy link
Member Author

@RainbowMango
Can you help to deal with this pull request ?

@wuyingjun-lucky
Copy link
Member Author

PTAL @RainbowMango

@lonelyCZ lonelyCZ mentioned this pull request Jul 29, 2022
Merged
@RainbowMango
Copy link
Member

@wuyingjun-lucky is this the latest test result?
Can you help update the test result to the PR description?

@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented Jul 29, 2022 •
edited

@wuyingjun-lucky is this the latest test result? Can you help update the test result to the PR description?

list and disable
image

@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented Jul 29, 2022 •
edited

@RainbowMango

enable
image

@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented Jul 29, 2022 •
edited

logsimage
image
image

@wuyingjun-lucky
Copy link
Member Author

search aa result
image

@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented Jul 29, 2022 •
edited

enable new cluster es
image

@wuyingjun-lucky
Copy link
Member Author

@wuyingjun-lucky is this the latest test result? Can you help update the test result to the PR description?

updated

@RainbowMango
Copy link
Member

Looks like it's a huge feature. Would you like to make a demo at the community meeting?

@prodanlabs Any comments?

@RainbowMango
Copy link
Member 

-bash-4.2# ./_output/bin/linux/amd64/karmadactl addons list --help 
List Karmada addons from Kubernetes

Does list mean to check whether supported addons are installed on a specific cluster?

In addition, enable/disable mean to install/install addons from a specific cluster?

@wuyingjun-lucky
Copy link
Member Author

Looks like it's a huge feature. Would you like to make a demo at the community meeting?

@prodanlabs Any comments?

Of course if we are able to attend the meeting

@wuyingjun-lucky
Copy link
Member Author 

-bash-4.2# ./_output/bin/linux/amd64/karmadactl addons list --help 
List Karmada addons from Kubernetes

Does list mean to check whether supported addons are installed on a specific cluster?

In addition, enable/disable mean to install/install addons from a specific cluster?

Yes

@RainbowMango
Copy link
Member

Great, looking forward to meeting you at the meeting.

@lonelyCZ lonelyCZ mentioned this pull request Aug 1, 2022
Closed
@wuyingjun-lucky
Copy link
Member Author

/reopen

@karmada-bot karmada-bot reopened this Aug 1, 2022
@karmada-bot
Copy link
Collaborator

@wuyingjun-lucky: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented Aug 1, 2022 •
edited

Bot Bug happend.
As #2283 merged. This pr closed as it refer to 2283 fix comments.
image

/cc @RainbowMango

RainbowMango
RainbowMango approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for your contribution. @wuyingjun-lucky

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@karmada-bot karmada-bot merged commit bda9703 into karmada-io:master Aug 2, 2022
@RainbowMango
Copy link
Member

Bot Bug happend.
As #2283 merged. This pr closed as it refer to 2283 fix comments.

:) Actually, this is GitHub behavior, not bot..., bot won't close issues when merging PRs.

@ONE7live ONE7live mentioned this pull request Sep 14, 2022
Closed
@wuyingjun-lucky wuyingjun-lucky deleted the karmada_addon branch November 8, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonelyCZ lonelyCZ lonelyCZ left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

Assignees

@RainbowMango RainbowMango

@prodanlabs prodanlabs

@lonelyCZ lonelyCZ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the plan of optional component to be installed by karmadactl
5 participants
@wuyingjun-lucky @lonelyCZ @RainbowMango @karmada-bot @prodanlabs