-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused flag for karmadactl promote #2193
Conversation
Signed-off-by: carlory <baofa.fan@daocloud.io>
8c92488
to
a78bc65
Compare
/assign @lonelyCZ @XiShanYongYe-Chang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to consider marking this flag as deprecated and remove it in next release?
#2190 is removed de directly. I'm not sure what rules to follow to remove unused flags /cc @RainbowMango |
For the flags that the user can't use, we can remove them directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
/lgtm
That's right. /lgtm |
@lonelyCZ @XiShanYongYe-Chang @RainbowMango Could you give me an |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: carlory baofa.fan@daocloud.io
What type of PR is this?
/kind bug
What this PR does / why we need it:
After #1795 is merged, the --cluster-namespace flag should be removed.
Does this PR introduce a user-facing change?: