Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch resourcebinding instead of update and update observed generation. #2330

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Set .status.schedulerObservedGeneration of ResourceBinding after schedule.

Which issue(s) this PR fixes:
Partof #2281

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE(include in graceful eviction feature)

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 4, 2022
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 4, 2022
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@mrlihanbo
Copy link

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 03eb521 into karmada-io:master Aug 5, 2022
@RainbowMango RainbowMango deleted the pr_patch_rb_conditions branch February 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants