Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce graceful eviction feature gate and mark feature in alpha state #2340

Merged

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR introduced a feature gate and defaults in alpha state.

Which issue(s) this PR fixes:
Part of #2281

Special notes for your reviewer:
The new feature gate presents in the command line as expected:

      --feature-gates mapStringBool                                                                                                                                                                                              
                A set of key=value pairs that describe feature gates for alpha/experimental features. Options are:
                AllAlpha=true|false (ALPHA - default=false)
                AllBeta=true|false (BETA - default=false)
                Failover=true|false (ALPHA - default=false)
                GracefulEviction=true|false (ALPHA - default=false)
                PropagateDeps=true|false (ALPHA - default=false)

Does this PR introduce a user-facing change?:

NONE(Included in Graceful Eviction Feature)

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 6, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2022
…ate.

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2022
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit a0a8b69 into karmada-io:master Aug 8, 2022
@RainbowMango RainbowMango deleted the pr_graceful_eviction_gate branch August 8, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants