patch resourcebinding instead of update and update observed generation. #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neration. Signed-off-by: yy158775 <1584616775@qq.com>
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
RainbowMango
reviewed
Aug 8, 2022
pkg/scheduler/scheduler_test.go
Outdated
| t.Error(err) | ||
| } | ||
| if !reflect.DeepEqual(res, test.expected) { | ||
| t.Errorf("Test %s Not Equal", test.name) |
There was a problem hiding this comment.
We don't need to log the test name as the name is already present in the result.
For example(I hacked the tests and let it fails) :
$ go test ./pkg/scheduler/... -run=Test_patchBindingScheduleStatus -v
=== RUN Test_patchBindingScheduleStatus
=== RUN Test_patchBindingScheduleStatus/add_success_condition
=== RUN Test_patchBindingScheduleStatus/add_failure_condition
=== RUN Test_patchBindingScheduleStatus/replace_to_success_condition
=== RUN Test_patchBindingScheduleStatus/replace_failure_condition
scheduler_test.go:171: Test replace failure condition Not Equal
The Test_patchBindingScheduleStatus/replace_failure_condition is exactly the test name.
pkg/scheduler/scheduler_test.go
Outdated
Comment on lines
170
to
172
| if !reflect.DeepEqual(res, test.expected) { | ||
| t.Errorf("Test %s Not Equal", test.name) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if !reflect.DeepEqual(res, test.expected) { | |
| t.Errorf("Test %s Not Equal", test.name) | |
| } | |
| if !reflect.DeepEqual(res.Status, test.expected.Status) { | |
| t.Errorf("expected status: %v, but got: %v", test.expected.Status, res.Status) | |
| } |
RainbowMango
reviewed
Aug 9, 2022
pkg/scheduler/scheduler_test.go
Outdated
| t.Error(err) | ||
| } | ||
| if !reflect.DeepEqual(res.Status, test.expected.Status) { | ||
| t.Errorf("Not Equal") |
RainbowMango
reviewed
Aug 9, 2022
pkg/scheduler/scheduler_test.go
Outdated
| t.Run(test.name, func(t *testing.T) { | ||
| _, err := karmadaClient.WorkV1alpha2().ResourceBindings(test.binding.Namespace).Create(context.TODO(), test.binding, metav1.CreateOptions{}) | ||
| if err != nil { | ||
| t.Error(err) |
There was a problem hiding this comment.
We should use Fatal or Fatalf here since if there is an error, we can skip following checks.
Signed-off-by: yy158775 <1584616775@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: