Add NotReady taint to the new cluster

[chaunceyjiang]

Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

There should be a taint during the period before the state of the newly added cluster becomes ready

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[RainbowMango]

Does it help #2301?

[edit]: Just see your comments at #2301 (comment).

[chaunceyjiang]

我认为有这样一种情况

当新加入的集群变Ready之前，NotReady 这个污点还没有来的及添加，集群就变成了Ready。

这样就会造成有一段时间集群状态不是Ready的，但是却没有污点。

简而言之，刚加入的集群它不是ready的，就应该带有NotReady污点

[chaunceyjiang]

Does it help #2301?

[edit]: Just see your comments at #2301 (comment).

Yes

[chaunceyjiang]

What do you think? @RainbowMango @Garrybest

[XiShanYongYe-Chang]

Hi @chaunceyjiang, maybe we needn't this modification, please see here.

[chaunceyjiang]

Hi @chaunceyjiang, maybe we needn't this modification, please see here.

I don't think so, please see #2301 (comment)

[chaunceyjiang]

I think when currentReadyCondition is nil,that mean the cluster status controller is not working yet, and we do not know the status of this cluster. Therefore, this cluster should be have a taint. If it is not tainted, it means that this cluster is normal, because the scheduler does not care about the cluster status, only about the cluster taint

[XiShanYongYe-Chang]

Thanks, NotReady will be an appropriate taint.
/lgtm

[RainbowMango]

@Garrybest @likakuli Could you please take a look?

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment