Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-specific cluster name support #2536

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

jwcesign
Copy link
Member

Signed-off-by: jwcesign jiangwei115@huawei.com

What type of PR is this?

/kind bug

What this PR does / why we need it:
If users want to set the cluster name by themselves like

xxx@ecs-3fa1 [03:13:06 PM] [~/workspace/git/karmada] [master *]
-> % tail ~/.zshrc
export PATH=$PATH:/home/jw/workspace/sf:/usr/local/go/bin/

# karmada env
export HOST_CLUSTER_NAME=jw-karmada-host
export MEMBER_CLUSTER_1_NAME=jw-member1-push
export MEMBER_CLUSTER_2_NAME=jw-member2-push
export PULL_MODE_CLUSTER_NAME=jw-member3-pull
export KIND_LOG_FILE=${HOME}/workspace/log/karmada

It will have errors:
image

Which issue(s) this PR fixes:
Bugs in script to set clusters name by users

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

none

Signed-off-by: jwcesign <jiangwei115@huawei.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2022
@karmada-bot
Copy link
Collaborator

Welcome @jwcesign! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2022
@jwcesign
Copy link
Member Author

cc @RainbowMango

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Thanks~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@karmada-bot karmada-bot merged commit d5eaf85 into karmada-io:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants