Update kind to 0.15 to support deploy k8s 1.25 environment #2551

jwcesign · 2022-09-20T09:32:13Z

Signed-off-by: jwcesign jiangwei115@huawei.com

What type of PR is this?
Update E2E environment to k8s v1.25

/kind failing-test

What this PR does / why we need it:
Add test k8s 1.25 test

Which issue(s) this PR fixes:
none
tests:

jw@ecs-3fa1 [05:23:49 PM] [~/workspace/git/karmada-diff/karmada-update-kind] [update-kind-to-1.25 *]
-> % docker ps
CONTAINER ID   IMAGE                  COMMAND                  CREATED          STATUS          PORTS                       NAMES
fbddb01e5fc7   kindest/node:v1.25.0   "/usr/local/bin/entr…"   13 minutes ago   Up 12 minutes   127.0.0.1:35387->6443/tcp   jw-member3-pull-control-plane
aa7a0a51ab49   kindest/node:v1.25.0   "/usr/local/bin/entr…"   13 minutes ago   Up 12 minutes   127.0.0.1:34003->6443/tcp   jw-member2-push-control-plane
ce3b647c7d27   kindest/node:v1.25.0   "/usr/local/bin/entr…"   13 minutes ago   Up 12 minutes   127.0.0.1:45591->6443/tcp   jw-karmada-host-control-plane
eed49f4ef491   kindest/node:v1.25.0   "/usr/local/bin/entr…"   13 minutes ago   Up 12 minutes   127.0.0.1:41437->6443/tcp   jw-member1-push-control-plane
b076a2371b44   kindest/node:v1.23.4   "/usr/local/bin/entr…"   30 hours ago     Up 30 hours     127.0.0.1:39799->6443/tcp   member1-control-plane
f126a23387b3   kindest/node:v1.23.4   "/usr/local/bin/entr…"   30 hours ago     Up 30 hours     127.0.0.1:35351->6443/tcp   member3-control-plane
920c4a47e006   kindest/node:v1.23.4   "/usr/local/bin/entr…"   30 hours ago     Up 30 hours     127.0.0.1:43553->6443/tcp   member2-control-plane
e1e1a78976a5   kindest/node:v1.23.4   "/usr/local/bin/entr…"   30 hours ago     Up 30 hours     127.0.0.1:43677->6443/tcp   karmada-host-control-plane
jw@ecs-3fa1 [05:19:49 PM] [~/workspace/git/karmada-diff/karmada-update-kind] [update-kind-to-1.25]
-> % kubectl version --context=jw-karmada-host
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1", GitCommit:"3ddd0f45aa91e2f30c70734b175631bec5b5825a", GitTreeState:"clean", BuildDate:"2022-05-24T12:26:19Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.0", GitCommit:"a866cbe2e5bbaa01cfd5e969aa3e033f3282a8a2", GitTreeState:"clean", BuildDate:"2022-09-01T23:30:43Z", GoVersion:"go1.19", Compiler:"gc", Platform:"linux/amd64"}
jw@ecs-3fa1 [05:22:42 PM] [~/workspace/git/karmada-diff/karmada-update-kind] [update-kind-to-1.25 *]
-> % kubectl apply -f samples/nginx/propagationpolicy.yaml
propagationpolicy.policy.karmada.io/nginx-propagation created
jw@ecs-3fa1 [05:22:50 PM] [~/workspace/git/karmada-diff/karmada-update-kind] [update-kind-to-1.25 *]
-> % kubectl apply -f samples/nginx/deployment.yaml
deployment.apps/nginx created
jw@ecs-3fa1 [05:23:10 PM] [~/workspace/git/karmada-diff/karmada-update-kind] [update-kind-to-1.25 *]
-> % karmadactl get pods -A
Error: unknown shorthand flag: 'A' in -A
jw@ecs-3fa1 [05:23:46 PM] [~/workspace/git/karmada-diff/karmada-update-kind] [update-kind-to-1.25 *]
-> % karmadactl get pods
The karmadactl get command now only supports Push mode, [ jw-member3-pull ] are not push mode

NAME                    CLUSTER           READY   STATUS    RESTARTS   AGE
nginx-76d6c9b8c-lsk2q   jw-member1-push   1/1     Running   0          39s
nginx-76d6c9b8c-fvn5j   jw-member2-push   1/1     Running   0          39s

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

none

jwcesign · 2022-09-20T09:34:50Z

artifacts/kindClusterConfig/general-config.yaml

@@ -4,8 +4,6 @@ networking:
  disableDefaultCNI: {{disable_cni}}
  podSubnet: {{pod_cidr}}
  serviceSubnet: {{service_cidr}}
-featureGates:


This feature is enabeled to be true by default after 1.19, so it's ok, ref to: https://v1-23.docs.kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

That means we don't need this flag, right? Since our E2E are started to v1.21.

Yes, we don't need it, it's enabled by default

Signed-off-by: jwcesign <jiangwei115@huawei.com>

XiShanYongYe-Chang

Thanks~
/lgtm

Could you state the reason for upgrading metalb in the comments? Just for the record.

XiShanYongYe-Chang · 2022-09-22T02:45:37Z

/cc @RainbowMango

jwcesign · 2022-09-22T02:53:51Z

Thanks~ /lgtm

Could you state the reason for upgrading metalb in the comments? Just for the record.

The metallb version is v0.12.1 before, it‘s not compatible with k8s v1.25; only the newest version(v0.13.5) metallb does, also:

the way to config ip range is changed.
before the ip given to interpreter-webhook-example is 172.18.0.6, it has conflicts when one new memeber cluster create(one it case will do), so change it to 172.18.0.8.

XiShanYongYe-Chang · 2022-09-22T03:04:03Z

/kind cleanup
/remove-kind failing-test
I update the labels.

RainbowMango

Good Job!
/approve

RainbowMango · 2022-09-22T03:01:18Z

artifacts/kindClusterConfig/general-config.yaml

@@ -4,8 +4,6 @@ networking:
  disableDefaultCNI: {{disable_cni}}
  podSubnet: {{pod_cidr}}
  serviceSubnet: {{service_cidr}}
-featureGates:


That means we don't need this flag, right? Since our E2E are started to v1.21.

karmada-bot · 2022-09-22T03:05:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 20, 2022

karmada-bot requested review from Garrybest and mrlihanbo September 20, 2022 09:32

karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 20, 2022

jwcesign force-pushed the update-kind-to-1.25.0 branch from 043eb64 to 46c7796 Compare September 20, 2022 09:33

jwcesign commented Sep 20, 2022

View reviewed changes

jwcesign force-pushed the update-kind-to-1.25.0 branch 5 times, most recently from 5aea634 to ac51da3 Compare September 21, 2022 06:49

karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2022

jwcesign force-pushed the update-kind-to-1.25.0 branch from ac51da3 to 58e302b Compare September 21, 2022 06:56

jwcesign changed the title ~~Update kind to 1.25~~ Update kind to 0.15 to support deloy k8s 1.25 environment Sep 21, 2022

jwcesign changed the title ~~Update kind to 0.15 to support deloy k8s 1.25 environment~~ Update kind to 0.15 to support deploy k8s 1.25 environment Sep 21, 2022

jwcesign force-pushed the update-kind-to-1.25.0 branch 5 times, most recently from 032273a to eeab487 Compare September 21, 2022 10:03

Update kind to 0.15 to support deploy k8s 1.25 environment

4f1436d

Signed-off-by: jwcesign <jiangwei115@huawei.com>

jwcesign force-pushed the update-kind-to-1.25.0 branch from eeab487 to 4f1436d Compare September 21, 2022 10:03

XiShanYongYe-Chang reviewed Sep 22, 2022

View reviewed changes

karmada-bot assigned XiShanYongYe-Chang Sep 22, 2022

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022

karmada-bot requested a review from RainbowMango September 22, 2022 02:45

karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Sep 22, 2022

RainbowMango approved these changes Sep 22, 2022

View reviewed changes

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022

karmada-bot merged commit 48d9ed1 into karmada-io:master Sep 22, 2022

RainbowMango mentioned this pull request Sep 27, 2022

Testing against kubernetes v1.25 #2467

Closed

jwcesign mentioned this pull request Oct 17, 2022

REQUEST: New membership for jwcesign karmada-io/community#12

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update kind to 0.15 to support deploy k8s 1.25 environment #2551

Update kind to 0.15 to support deploy k8s 1.25 environment #2551

jwcesign commented Sep 20, 2022 •

edited

jwcesign Sep 20, 2022 •

edited

XiShanYongYe-Chang Sep 22, 2022

RainbowMango Sep 22, 2022

jwcesign Sep 22, 2022

XiShanYongYe-Chang left a comment

XiShanYongYe-Chang commented Sep 22, 2022

jwcesign commented Sep 22, 2022

XiShanYongYe-Chang commented Sep 22, 2022

RainbowMango left a comment

RainbowMango Sep 22, 2022

karmada-bot commented Sep 22, 2022

Update kind to 0.15 to support deploy k8s 1.25 environment #2551

Update kind to 0.15 to support deploy k8s 1.25 environment #2551

Conversation

jwcesign commented Sep 20, 2022 • edited

jwcesign Sep 20, 2022 • edited

Choose a reason for hiding this comment

XiShanYongYe-Chang Sep 22, 2022

Choose a reason for hiding this comment

RainbowMango Sep 22, 2022

Choose a reason for hiding this comment

jwcesign Sep 22, 2022

Choose a reason for hiding this comment

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

XiShanYongYe-Chang commented Sep 22, 2022

jwcesign commented Sep 22, 2022

XiShanYongYe-Chang commented Sep 22, 2022

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango Sep 22, 2022

Choose a reason for hiding this comment

karmada-bot commented Sep 22, 2022

jwcesign commented Sep 20, 2022 •

edited

jwcesign Sep 20, 2022 •

edited