Disable webhook-mode for metallb #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
size/XS
jwcesign
changed the title
jwcesign
force-pushed
the
update-kind-to-1.25.0
branch
from
9143607
to
64888a3
Compare
jwcesign
changed the title
jwcesign
force-pushed
the
update-kind-to-1.25.0
branch
from
64888a3
to
85bbc6c
Compare
jwcesign
force-pushed
the
update-kind-to-1.25.0
branch
from
85bbc6c
to
d6f3364
Compare
karmada-bot
added
size/S
ikaven1024
reviewed
Sep 22, 2022
hack/post-run-e2e.sh
Outdated
| curl https://raw.githubusercontent.com/metallb/metallb/v0.13.5/config/manifests/metallb-native.yaml -k | \ | ||
| sed '0,/args:/s//args:\n - --webhook-mode=disabled/' | \ | ||
| sed '/apiVersion: admissionregistration/,$d' | \ | ||
| kubectl --context="${HOST_CLUSTER_NAME}" delete -f - |
There was a problem hiding this comment.
Why shall we sed it when deleting?
There was a problem hiding this comment.
command sed '/apiVersion: admissionregistration/,$d' will delete one ValidatingWebhookConfiguration, if not delete it before, kubectl delete will have erros:
jw@ecs-3fa1 [04:23:37 PM] [~]
-> % kubectl delete -f https://raw.githubusercontent.com/metallb/metallb/v0.13.5/config/manifests/metallb-native.yaml
namespace "metallb-system" deleted
customresourcedefinition.apiextensions.k8s.io "addresspools.metallb.io" deleted
customresourcedefinition.apiextensions.k8s.io "bfdprofiles.metallb.io" deleted
customresourcedefinition.apiextensions.k8s.io "bgpadvertisements.metallb.io" deleted
customresourcedefinition.apiextensions.k8s.io "bgppeers.metallb.io" deleted
customresourcedefinition.apiextensions.k8s.io "communities.metallb.io" deleted
customresourcedefinition.apiextensions.k8s.io "ipaddresspools.metallb.io" deleted
customresourcedefinition.apiextensions.k8s.io "l2advertisements.metallb.io" deleted
serviceaccount "controller" deleted
serviceaccount "speaker" deleted
role.rbac.authorization.k8s.io "controller" deleted
role.rbac.authorization.k8s.io "pod-lister" deleted
clusterrole.rbac.authorization.k8s.io "metallb-system:controller" deleted
clusterrole.rbac.authorization.k8s.io "metallb-system:speaker" deleted
rolebinding.rbac.authorization.k8s.io "controller" deleted
rolebinding.rbac.authorization.k8s.io "pod-lister" deleted
clusterrolebinding.rbac.authorization.k8s.io "metallb-system:controller" deleted
clusterrolebinding.rbac.authorization.k8s.io "metallb-system:speaker" deleted
secret "webhook-server-cert" deleted
service "webhook-service" deleted
deployment.apps "controller" deleted
daemonset.apps "speaker" deleted
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/metallb/metallb/v0.13.5/config/manifests/metallb-native.yaml": validatingwebhookconfigurations.admissionregistration.k8s.io "metallb-webhook-configuration" not found
There was a problem hiding this comment.
@ikaven1024 Do you want to say, why not use --ignore-not-found?
$ kubectl delete --help
--ignore-not-found=false:
Treat "resource not found" as a successful delete. Defaults to "true" when --all is
specified.
|
retriggered the tests. |
Signed-off-by: jwcesign <jiangwei115@huawei.com>
jwcesign
force-pushed
the
update-kind-to-1.25.0
branch
from
d6f3364
to
abf026a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jwcesign jiangwei115@huawei.com
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
There is a bug in metallb: metallb/metallb#1597
Disable the webhook-mode, also it has not effects for our test case.
Which issue(s) this PR fixes:
There is a bug in metallb: metallb/metallb#1597
Disable the webhook-mode, also it has not effects for our test case.
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: