-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm chart support configuration for ca key #2637
Conversation
Welcome @631068264! It looks like this is your first PR to karmada-io/karmada 🎉 |
Thanks for your work and seems like this PR is work for support configuration for ca key. So could you change the title for this. like |
kube-controller-manager crash by missing /etc/karmada/pki/server-ca.key Signed-off-by: 吴雨羲 <l631068264@gmail.com>
Changed |
cc @Poor12 for review |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix use custom certs lead to post-install-job failed and kube-controller-manager crash by missing /etc/karmada/pki/server-ca.key
What type of PR is this?
/kind bug
What this PR does / why we need it:
helm install 使用自定义证书
kubectl apply -f /static-resources --kubeconfig /etc/kubeconfig
因为yaml格式问题运行不了,导致安装失败/etc/karmada/pki/server-ca.key
,custom模式没有传入,auto是有的Which issue(s) this PR fixes:
Fixes #2628 (comment) 提到的问题
Special notes for your reviewer:
Does this PR introduce a user-facing change?: