Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart support configuration for ca key #2637

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

631068264
Copy link
Contributor

@631068264 631068264 commented Oct 13, 2022

fix use custom certs lead to post-install-job failed and kube-controller-manager crash by missing /etc/karmada/pki/server-ca.key

What type of PR is this?
/kind bug

What this PR does / why we need it:
helm install 使用自定义证书

  • post-install-job 运行失败,kubectl apply -f /static-resources --kubeconfig /etc/kubeconfig 因为yaml格式问题运行不了,导致安装失败
  • kube-controller-manager 运行时报错no such file缺失/etc/karmada/pki/server-ca.key ,custom模式没有传入,auto是有的

Which issue(s) this PR fixes:
Fixes #2628 (comment) 提到的问题

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 13, 2022
@karmada-bot
Copy link
Collaborator

Welcome @631068264! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2022
@631068264 631068264 changed the title fix use custom certs lead to post-install-job failed and fix use custom certs lead to post-install-job failed and kube-controller-manager crash by missing /etc/karmada/pki/server-ca.key Oct 13, 2022
@liangyuanpeng
Copy link
Contributor

Thanks for your work and seems like this PR is work for support configuration for ca key. So could you change the title for this. like helm chart support configuration for ca key.

@631068264 631068264 changed the title fix use custom certs lead to post-install-job failed and kube-controller-manager crash by missing /etc/karmada/pki/server-ca.key helm chart support configuration for ca key Oct 13, 2022
kube-controller-manager crash by missing /etc/karmada/pki/server-ca.key

Signed-off-by: 吴雨羲 <l631068264@gmail.com>
@631068264
Copy link
Contributor Author

Thanks for your work and seems like this PR is work for support configuration for ca key. So could you change the title for this. like helm chart support configuration for ca key.

Changed

@631068264
Copy link
Contributor Author

@pidb @jrkeen

@RainbowMango
Copy link
Member

cc @Poor12 for review

@Poor12
Copy link
Member

Poor12 commented Oct 14, 2022

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@karmada-bot karmada-bot merged commit 07ddc07 into karmada-io:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANP cluster is inaccessible, please check authorization or network /proxy/api 503 Service Unavailable
5 participants