introduce `--private-image-registry` flag to `karmadactl init` #2655

helen-frank · 2022-10-18T16:36:56Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
At present, it is mainly used for offline installation karmada to simplify installation commands.
Which issue(s) this PR fixes:
Fixes #
Port of #2541
Special notes for your reviewer:
Test

# go run cmd/karmadactl/karmadactl.go init --image-registry=xxx/xxx --crds /root/crds.tar.gz
I1019 00:34:22.710879 1942695 deploy.go:188] kubeconfig file: /root/.kube/config, kubernetes: https://10.29.12.229:44230
I1019 00:34:22.732691 1942695 deploy.go:208] karmada apiserver ip: [172.18.0.4]
I1019 00:34:23.492457 1942695 cert.go:229] Generate ca certificate success.
I1019 00:34:23.695980 1942695 cert.go:229] Generate karmada certificate success.
I1019 00:34:24.011098 1942695 cert.go:229] Generate apiserver certificate success.
I1019 00:34:24.497476 1942695 cert.go:229] Generate front-proxy-ca certificate success.
I1019 00:34:24.798200 1942695 cert.go:229] Generate front-proxy-client certificate success.
I1019 00:34:25.060485 1942695 cert.go:229] Generate etcd-ca certificate success.
I1019 00:34:25.309735 1942695 cert.go:229] Generate etcd-server certificate success.
I1019 00:34:25.391543 1942695 cert.go:229] Generate etcd-client certificate success.
...
------------------------------------------------------------------------------------------------------
 █████   ████   █████████   ███████████   ██████   ██████   █████████   ██████████     █████████
░░███   ███░   ███░░░░░███ ░░███░░░░░███ ░░██████ ██████   ███░░░░░███ ░░███░░░░███   ███░░░░░███
 ░███  ███    ░███    ░███  ░███    ░███  ░███░█████░███  ░███    ░███  ░███   ░░███ ░███    ░███
 ░███████     ░███████████  ░██████████   ░███░░███ ░███  ░███████████  ░███    ░███ ░███████████
 ░███░░███    ░███░░░░░███  ░███░░░░░███  ░███ ░░░  ░███  ░███░░░░░███  ░███    ░███ ░███░░░░░███
 ░███ ░░███   ░███    ░███  ░███    ░███  ░███      ░███  ░███    ░███  ░███    ███  ░███    ░███
 █████ ░░████ █████   █████ █████   █████ █████     █████ █████   █████ ██████████   █████   █████
░░░░░   ░░░░ ░░░░░   ░░░░░ ░░░░░   ░░░░░ ░░░░░     ░░░░░ ░░░░░   ░░░░░ ░░░░░░░░░░   ░░░░░   ░░░░░
------------------------------------------------------------------------------------------------------
Karmada is installed successfully.

Register Kubernetes cluster to Karmada control plane.

Register cluster with 'Push' mode

Does this PR introduce a user-facing change?:

`karmadactl`: `init` add `--image-registry` flags

helen-frank · 2022-10-18T16:59:10Z

swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-controller-manager:v1.3.0
swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-scheduler:v1.3.0
swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-webhook:v1.3.0
swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-aggregated-apiserver:v1.3.0
docker.io/alpine:3.15.1
registry.cn-hangzhou.aliyuncs.com/google_containers/etcd:3.5.3-0
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-apiserver:v1.25.2
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-controller-manager:v1.25.2

Currently testing image-registry needs to push these images into the image repository.

helen-frank · 2022-10-18T17:00:54Z

swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-controller-manager:v1.3.0
swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-scheduler:v1.3.0
swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-webhook:v1.3.0
swr.ap-southeast-1.myhuaweicloud.com/karmada/karmada-aggregated-apiserver:v1.3.0
docker.io/alpine:3.15.1
registry.cn-hangzhou.aliyuncs.com/google_containers/etcd:3.5.3-0
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-apiserver:v1.25.2
registry.cn-hangzhou.aliyuncs.com/google_containers/kube-controller-manager:v1.25.2

Currently testing image-registry needs to push these images into the image repository.

I will develop image-tag after this pr (tentative name)

helen-frank · 2022-10-19T02:50:28Z

For quick testing, I have provided a mirror warehouse here.

./karmadactl init --image-registry=daocloud.io/atsctoo

lonelyCZ · 2022-10-19T07:34:44Z

Thanks for your contribute. I will review it!

/assign

lonelyCZ · 2022-10-25T02:11:09Z

pkg/karmadactl/cmdinit/cmdinit.go

-		releaseVer = &version.ReleaseVersion{} // initialize to avoid panic
-	}
+	// image registry
+	flags.StringVarP(&opts.ImageRegistry, "image-registry", "", "", "Image registry.")


We could add more detail description for image-registry.

Image registry. Registry containing karmada all image

Whether such a description is readable ?

Perhaps, you can look up and refer other projects. Then we can compare and determine a good description.

https://github.com/kubernetes/kubernetes/blob/449c46258b0e36b80d590ffcc26bd43ecfb60132/cmd/kubeadm/app/cmd/options/generic.go#L64

Choose a container registry to pull control plane images from

It looks good.

cc @RainbowMango

pkg/karmadactl/cmdinit/kubernetes/deploy.go

helen-frank · 2022-11-02T01:52:56Z

export karmada_registry="harbor.xxx.xx/xxx"

karmadactl init --etcd-image=$karmada_registry/etcd:3.5.3-0 \
--etcd-init-image=$karmada_registry/alpine:3.15.1 \
--karmada-aggregated-apiserver-image=$karmada_registry/karmada-aggregated-apiserver:v1.3.1 \
--karmada-apiserver-image=$karmada_registry/kube-apiserver:v1.18.20 \
--karmada-controller-manager-image=$karmada_registry/karmada-controller-manager:v1.3.1 \
--karmada-kube-controller-manager-image=$karmada_registry/kube-controller-manager:v1.18.20 \
--karmada-scheduler-image=$karmada_registry/karmada-scheduler:v1.3.1 \
--karmada-webhook-image=$karmada_registry/karmada-webhook:v1.3.1 \
--crds=./crds.tar.gz

In yesterday's document, I need to give the command of karmada offline installation, which makes me a little painful.🥲
/cc @RainbowMango

helen-frank · 2022-11-07T08:29:04Z

/cc @RainbowMango

RainbowMango · 2022-11-07T08:31:24Z

@lonelyCZ Do you have any other comments?

lonelyCZ · 2022-11-07T08:34:52Z

Looks good, I will test it in my env today.

lonelyCZ · 2022-11-07T09:06:16Z

Hi, @helen-frank could you please help to resolve the conflicts? I will test it ASAP.

RainbowMango · 2022-11-16T04:20:12Z

Generally looks good to me. But I didn't test it on my side.
Leave approval to @lonelyCZ

lonelyCZ · 2022-11-16T16:08:10Z

It works fine in my env. :)

Thanks @helen-frank

/lgtm
/approve

And please update Does this PR introduce a user-facing change? in this PR.

RainbowMango · 2022-11-17T01:45:39Z

/retitle introduce --private-image-registry flag to karmadactl init

RainbowMango · 2022-11-17T01:47:10Z

In addition to the release notes that @lonelyCZ asked for above, please also update the PR descriptions as per the latest content.

helen-frank · 2022-11-17T01:55:31Z

OK, I rested earlier yesterday and updated it immediately.

Signed-off-by: helen <haitao.zhang@daocloud.io>

karmada-bot · 2022-11-17T01:57:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/karmadactl/cmdinit/OWNERS~~ [lonelyCZ]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lonelyCZ · 2022-11-17T03:30:31Z

/lgtm

karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 18, 2022

karmada-bot requested review from carlory and prodanlabs October 18, 2022 16:36

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2022

helen-frank force-pushed the feature/karmada-image-registry branch from e81a163 to aa600c3 Compare October 18, 2022 16:37

helen-frank changed the title ~~add image-registry~~ karmadactl int add image-registry flags Oct 18, 2022

helen-frank changed the title ~~karmadactl int add image-registry flags~~ karmadactl init add image-registry flags Oct 18, 2022

karmada-bot assigned lonelyCZ Oct 19, 2022

lonelyCZ reviewed Oct 25, 2022

View reviewed changes

helen-frank force-pushed the feature/karmada-image-registry branch from aa600c3 to 06fa84b Compare October 31, 2022 08:58

karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2022

helen-frank force-pushed the feature/karmada-image-registry branch from 06fa84b to 004374a Compare October 31, 2022 08:59

karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2022

karmada-bot requested a review from RainbowMango November 2, 2022 01:52

karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2022

helen-frank force-pushed the feature/karmada-image-registry branch from 06b0287 to 5e25398 Compare November 15, 2022 14:10

helen-frank requested review from RainbowMango and lonelyCZ and removed request for carlory, prodanlabs, RainbowMango and lonelyCZ November 15, 2022 14:11

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022

karmada-bot changed the title ~~karmadactl init add image-registry flags~~ introduce --private-image-registry flag to karmadactl init Nov 17, 2022

introduce --private-image-registry flag to karmadactl init

d4f2104

Signed-off-by: helen <haitao.zhang@daocloud.io>

helen-frank force-pushed the feature/karmada-image-registry branch from 5e25398 to d4f2104 Compare November 17, 2022 01:56

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022

karmada-bot merged commit 9a4a668 into karmada-io:master Nov 17, 2022

helen-frank mentioned this pull request Nov 20, 2022

introduce kube-image-tag flag to karmadactl init #2840

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introduce `--private-image-registry` flag to `karmadactl init` #2655

introduce `--private-image-registry` flag to `karmadactl init` #2655

helen-frank commented Oct 18, 2022 •

edited

helen-frank commented Oct 18, 2022

helen-frank commented Oct 18, 2022

helen-frank commented Oct 19, 2022 •

edited

lonelyCZ commented Oct 19, 2022

lonelyCZ Oct 25, 2022

helen-frank Oct 25, 2022

lonelyCZ Oct 25, 2022

helen-frank Oct 25, 2022

lonelyCZ Oct 28, 2022

helen-frank commented Nov 2, 2022

helen-frank commented Nov 7, 2022

RainbowMango commented Nov 7, 2022

lonelyCZ commented Nov 7, 2022

lonelyCZ commented Nov 7, 2022

RainbowMango commented Nov 16, 2022

lonelyCZ commented Nov 16, 2022

RainbowMango commented Nov 17, 2022

RainbowMango commented Nov 17, 2022

helen-frank commented Nov 17, 2022

karmada-bot commented Nov 17, 2022

lonelyCZ commented Nov 17, 2022

introduce --private-image-registry flag to karmadactl init #2655

introduce --private-image-registry flag to karmadactl init #2655

Conversation

helen-frank commented Oct 18, 2022 • edited

helen-frank commented Oct 18, 2022

helen-frank commented Oct 18, 2022

helen-frank commented Oct 19, 2022 • edited

lonelyCZ commented Oct 19, 2022

lonelyCZ Oct 25, 2022

Choose a reason for hiding this comment

helen-frank Oct 25, 2022

Choose a reason for hiding this comment

lonelyCZ Oct 25, 2022

Choose a reason for hiding this comment

helen-frank Oct 25, 2022

Choose a reason for hiding this comment

lonelyCZ Oct 28, 2022

Choose a reason for hiding this comment

helen-frank commented Nov 2, 2022

helen-frank commented Nov 7, 2022

RainbowMango commented Nov 7, 2022

lonelyCZ commented Nov 7, 2022

lonelyCZ commented Nov 7, 2022

RainbowMango commented Nov 16, 2022

lonelyCZ commented Nov 16, 2022

RainbowMango commented Nov 17, 2022

RainbowMango commented Nov 17, 2022

helen-frank commented Nov 17, 2022

karmada-bot commented Nov 17, 2022

lonelyCZ commented Nov 17, 2022

introduce `--private-image-registry` flag to `karmadactl init` #2655

introduce `--private-image-registry` flag to `karmadactl init` #2655

helen-frank commented Oct 18, 2022 •

edited

helen-frank commented Oct 19, 2022 •

edited