-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ut] add ut for pkg/util/clusterrole, rbac, sercret, secret, serviceaccount #2669
Conversation
c586215
to
74c2c48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Other parts look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Just a question need to confirm.
Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
74c2c48
to
ee73db8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yingjinhui yingjinhui@didiglobal.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
add ut for pkg/util/clusterrole, rbac, sercret, secret, serviceaccount
Which issue(s) this PR fixes:
Part #2579
Special notes for your reviewer:
Does this PR introduce a user-facing change?: