fix: Validate replicaSchedulingType and replicaDivisionPreference

[chaunceyjiang]

Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com

What type of PR is this?
/kind bug

What this PR does / why we need it:
Validate replicaSchedulingType and replicaDivisionPreference
Which issue(s) this PR fixes:
Fixes #3013

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-webhook`: Validate replicaSchedulingType and replicaDivisionPreference.

[chaunceyjiang]

apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: nginx-propagation
spec:
  resourceSelectors:
    - apiVersion: apps/v1
      kind: Deployment
      name: nginx
  placement:
    clusterAffinity:
      clusterNames:
        - member1
        - member2
    replicaScheduling:
      replicaDivisionPreference: Weighted

apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: nginx-propagation
spec:
  resourceSelectors:
    - apiVersion: apps/v1
      kind: Deployment
      name: nginx
  placement:
    clusterAffinity:
      clusterNames:
        - member1
        - member2
    replicaScheduling:
      replicaSchedulingType: Divided

[codecov-commenter]

Codecov Report

Merging #3014 (7a3207c) into master (617409f) will increase coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
+ Coverage   38.61%   38.74%   +0.12%     
==========================================
  Files         206      206              
  Lines       18808    18919     +111     
==========================================
+ Hits         7263     7330      +67     
- Misses      11115    11155      +40     
- Partials      430      434       +4     

Flag	Coverage Δ
unittests	38.74% <0.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/util/helper/policy.go	81.60% <0.00%> (-4.98%)	⬇️
pkg/search/proxy/controller.go	83.97% <0.00%> (-1.65%)	⬇️
.../resourceinterpreter/defaultinterpreter/healthy.go	65.76% <0.00%> (-1.23%)	⬇️
...einterpreter/defaultinterpreter/aggregatestatus.go	72.09% <0.00%> (-0.85%)	⬇️
pkg/scheduler/core/division_algorithm.go	85.71% <0.00%> (-0.38%)	⬇️
pkg/scheduler/scheduler.go	18.07% <0.00%> (-0.23%)	⬇️
pkg/util/names/names.go	96.38% <0.00%> (-0.17%)	⬇️
pkg/util/namespace.go	100.00% <0.00%> (ø)
pkg/detector/detector.go	0.00% <0.00%> (ø)
pkg/scheduler/core/assignment.go	79.76% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Garrybest]

BTW, policyv1 really needs to be promoted and collated because some fields are not decent enough🤔.

[RainbowMango]

/assign

[Garrybest]

Emmm🤔, I think this solution does not have an effect on #3013 because the empty field is ReplicaDivisionPreference.

[RainbowMango]

Yes, It looks good for this instruction.

But it can't fix #3013.

For the ReplicaDivisionPreference, maybe we can't just set a default value by kubebuilder instruction, because it has a precondition that is when replicaSchedulingType is Divided.

How about deal replicaSchedulingType with the mutating webhook?

[Garrybest]

+1. Meanwhile, I suggest we gather our own default function of all API objects in zz_generated.defaults.go which generated by code-generator and fill up with the default value in mutating webhook.

[RainbowMango]

I'm interested in the defaults thing, is there an example?

[Garrybest]

Take corev1.Pod as an example. AFAIK, the code-generator helps us generate zz_generated.defaults.go and we only need to implement the customized default function in defaults.go. Once the scheme is added, we could use these codes to dump all default values into an object.

[chaunceyjiang]

the code-generator helps us generate zz_generated.defaults.go

https://pkg.go.dev/k8s.io/code-generator/cmd/defaulter-gen

this?

[Garrybest]

Right, I have used this tool before.

[chaunceyjiang]

yaml

apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: nginx-propagation
spec:
  resourceSelectors:
    - apiVersion: apps/v1
      kind: Deployment
      name: nginx
  placement:
    clusterAffinity:
      clusterNames:
        - member1
        - member2
    replicaScheduling:
      replicaSchedulingType: Divided

[RainbowMango]

/approve

Please @Garrybest take a look?

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chaunceyjiang]

apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: nginx-propagation3
spec:
  resourceSelectors:
    - apiVersion: apps/v1
      kind: Deployment
      name: nginx
  placement:
    clusterAffinity:
      clusterNames:
        - member1
        - member2
    replicaScheduling:
      weightPreference:
        staticWeightList:
          - targetCluster:
              clusterNames:
                - member1
            weight: 1
          - targetCluster:
              clusterNames:
                - member2
            weight: 1

[Garrybest]

/lgtm

Thanks😄.