Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3010: search filter out not ready cluster #3016

Conversation

yanfeng1992
Copy link
Member

@yanfeng1992 yanfeng1992 commented Jan 3, 2023

Cherry pick of #3010 on release-1.4.
#3010: search filter out not ready cluster
For details on the cherry pick process, see the cherry pick requests page.

karmada-search: filter out not ready clusters

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>

search filter out not ready cluster fix ut

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>

search filter out not ready cluster fix lint

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>

search filter out not ready cluster fix log and add comment

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>

search filter out not ready cluster fix  comment

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 3, 2023
@yanfeng1992
Copy link
Member Author

image

how to solve this problem
@XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

how to solve this problem

Ask for @RainbowMango to help rerun the CI.

@yanfeng1992
Copy link
Member Author

need your help to rerun the CI. @RainbowMango

@RainbowMango
Copy link
Member

Done.

@yanfeng1992
Copy link
Member Author

rerun the CI done @XiShanYongYe-Chang

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@karmada-bot karmada-bot merged commit e30d713 into karmada-io:release-1.4 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants