Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #2524: propagate dependencies support propagate sa #3222

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Automated cherry pick of #2524: propagate dependencies support propagate sa #3222

merged 2 commits into from
Mar 1, 2023

Conversation

whitewindmills
Copy link
Member

@whitewindmills whitewindmills commented Feb 28, 2023 •
edited by RainbowMango
Loading

Cherry pick of #2524 on release-1.3.
#2524: propagate dependencies support propagate sa
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the problem that ServiceAccount can be interpreted as a dependency, but may not be delivered

@chaunceyjiang @whitewindmills
propagate dependencies support propagate sa
eaec215 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2023
@XiShanYongYe-Chang
Copy link
Member

/cc @chaunceyjiang
Ask for @chaunceyjiang to help take a review.

@XiShanYongYe-Chang
Copy link
Member

@whitewindmills Thanks~
Can you help update the release note to a meaningful description of user-oriented modifications? We need this info when we release the new tag.

@whitewindmills whitewindmills mentioned this pull request Feb 28, 2023
Closed
@whitewindmills
Copy link
Member Author

@whitewindmills Thanks~ Can you help update the release note to a meaningful description of user-oriented modifications? We need this info when we release the new tag.

Okay

@chaunceyjiang
Copy link
Member

image

Why are there two commits ?

@whitewindmills
Copy link
Member Author

image

Why are there two commits ?

I added the UT here.

@whitewindmills @yanfeng1992
add ut
9dc5762 
Co-authored-by: huangyanfeng <huangyanfeng1992@gmail.com>
Signed-off-by: hejunhua <jayfantasyhjh@gmail.com>
@whitewindmills whitewindmills force-pushed the automated-cherry-pick-of-#2524-upstream-release-1.3 branch from 318cf27 to 9dc5762 Compare March 1, 2023 03:39
@whitewindmills
Copy link
Member Author

@XiShanYongYe-Chang Hi, can you approve it?

@chaunceyjiang
Copy link
Member

LGTM

@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang Hi, can you approve it?

Yes, thanks~

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@XiShanYongYe-Chang
Copy link
Member

/cc @RainbowMango

RainbowMango
RainbowMango approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@karmada-bot karmada-bot merged commit 4dff6c8 into karmada-io:release-1.3 Mar 1, 2023
@whitewindmills whitewindmills deleted the automated-cherry-pick-of-#2524-upstream-release-1.3 branch March 8, 2023 02:15
@whitewindmills whitewindmills mentioned this pull request Mar 30, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@whitewindmills @XiShanYongYe-Chang @chaunceyjiang @karmada-bot @RainbowMango