Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specify global image registry for enable addons #3345

Merged
merged 1 commit into from Apr 6, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Mar 30, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
If we use 'karmadactl addons init' to enable multiple addons, it is a good experience to specify a global image repository for all images.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`:  Introduced `--private-image-registry` flag to `addons` command to specify image registry.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 30, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2023
@my-git9
Copy link
Member Author

my-git9 commented Mar 30, 2023

The test result:
image

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #3345 (8adc86e) into master (5194e17) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
+ Coverage   51.50%   51.54%   +0.04%     
==========================================
  Files         210      210              
  Lines       18850    18874      +24     
==========================================
+ Hits         9709     9729      +20     
- Misses       8642     8644       +2     
- Partials      499      501       +2     
Flag Coverage Δ
unittests 51.54% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@my-git9
Copy link
Member Author

my-git9 commented Apr 3, 2023

/cc @RainbowMango @Poor12

Signed-off-by: xin.li <xin.li@daocloud.io>
@Poor12
Copy link
Member

Poor12 commented Apr 4, 2023

LGTM
/cc addons owner @wuyingjun-lucky

@karmada-bot
Copy link
Collaborator

@Poor12: GitHub didn't allow me to request PR reviews from the following users: owner.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

LGTM
/cc addons owner @wuyingjun-lucky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuyingjun-lucky
Copy link
Member

Can you post the latest test result ?

@my-git9
Copy link
Member Author

my-git9 commented Apr 4, 2023

The test result:
Specify private-image-registry
image

By default:
image
/cc @wuyingjun-lucky

@wuyingjun-lucky
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@wuyingjun-lucky
Copy link
Member

wuyingjun-lucky commented Apr 4, 2023

@my-git9 It seems lack of es ,can you add the es result ?

@my-git9
Copy link
Member Author

my-git9 commented Apr 4, 2023

@my-git9 It seems lack of es ,can you add the es result ?
The test result which include es:

image

@wuyingjun-lucky
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@karmada-bot karmada-bot merged commit 13ecfa5 into karmada-io:master Apr 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants