enable mcs to support headless-svc #3372

wenchezhao · 2023-04-07T03:46:15Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
enable mcs to support headless-svc
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chaunceyjiang · 2023-04-07T03:52:23Z

Just a question，why do you need to enable mcs to support headless-svc?

When ServiceImportType is Headless, it should be ignored

Refer to shouldIgnoreImport

codecov-commenter · 2023-04-07T04:04:56Z

Codecov Report

Merging #3372 (b1fbec5) into master (7589eae) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3372   +/-   ##
=======================================
  Coverage   51.61%   51.62%           
=======================================
  Files         210      210           
  Lines       18922    18922           
=======================================
+ Hits         9767     9768    +1     
+ Misses       8629     8628    -1     
  Partials      526      526

Flag	Coverage Δ
unittests	`51.62% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wenchezhao · 2023-04-07T05:44:32Z

Just a question，why do you need to enable mcs to support headless-svc?

When ServiceImportType is Headless, it should be ignored

Refer to shouldIgnoreImport

I have a use case that requires mcs to support headless-svc, but I don’t understand why mcs-api doesn’t support it. However, I think this is a useful feature.

XiShanYongYe-Chang · 2023-04-07T06:16:20Z

I have a use case that requires mcs to support headless-svc, but I don’t understand why mcs-api doesn’t support it. However, I think this is a useful feature.

Thanks~ @wenchezhao

How do you use the headless service? Can you give your test report?

Maybe we can perfect our MCS documentation.

wenchezhao · 2023-04-07T06:53:52Z

How do you use the headless service? Can you give your test report?

Maybe we can perfect our MCS documentation.

Nothing special, a statefulset application, the svc is headless, and when the svc is exported, it also needs to be headless. Therefore, the type of ServiceImport needs to be Headless.

RainbowMango

/assign @XiShanYongYe-Chang

XiShanYongYe-Chang · 2023-04-10T01:28:44Z

Nothing special, a statefulset application, the svc is headless, and when the svc is exported, it also needs to be headless. Therefore, the type of ServiceImport needs to be Headless.

@wenchezhao, can you post your test report?

wenchezhao · 2023-04-10T02:24:38Z

@wenchezhao, can you post your test report?

hi, @XiShanYongYe-Chang this is my test yaml. If you need anything else, please let me know.

apiVersion: apps/v1
kind: StatefulSet
metadata:
  labels:
    app: web
  name: web
spec:
  replicas: 3
  selector:
    matchLabels:
      app: web
  serviceName: my-service
  template:
    metadata:
      labels:
        app: web
    spec:
      containers:
      - image: nginx
        imagePullPolicy: IfNotPresent
        name: web
        ports:
        - containerPort: 8000
---
apiVersion: v1
kind: Service
metadata:
  name: my-service
  annotations:
    mcs/localAnalysis: 'true'
spec:
  ports:
  - port: 80
    targetPort: 8000
  selector:
    app: web
  clusterIP: None
---
apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: mynginx-workload
spec:
  resourceSelectors:
    - apiVersion: apps/v1
      kind: StatefulSet
      name: web
    - apiVersion: v1
      kind: Service
      name: my-service
  placement:
    clusterAffinity:
      clusterNames:
        - k8s86
        - k8s74
---
apiVersion: multicluster.x-k8s.io/v1alpha1
kind: ServiceExport
metadata:
  name: my-service
---
apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: serve-export-policy
spec:
  resourceSelectors:
    - apiVersion: multicluster.x-k8s.io/v1alpha1
      kind: ServiceExport
      name: my-service
  placement:
    clusterAffinity:
      clusterNames:
        - k8s86
        - k8s74
---
apiVersion: multicluster.x-k8s.io/v1alpha1
kind: ServiceImport
metadata:
  name: my-service
spec:
#  type: ClusterSetIP
  type: Headless
  ports:
  - port: 80
    protocol: TCP
---
apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: serve-import-policy
spec:
  resourceSelectors:
    - apiVersion: multicluster.x-k8s.io/v1alpha1
      kind: ServiceImport
      name: my-service
  placement:
    clusterAffinity:
      clusterNames:
        - k8s86

XiShanYongYe-Chang · 2023-04-10T06:19:45Z

Hi @wenchezhao, thanks for your quick response, have you successfully tested the headless service on your local site?

wenchezhao · 2023-04-10T06:45:11Z

Hi @wenchezhao, thanks for your quick response, have you successfully tested the headless service on your local site?

yes, after I made the changes, the headless-svc can be imported into the target cluster.

XiShanYongYe-Chang · 2023-04-10T09:28:03Z

Hi @wenchezhao, I'd like to know some more information, please don't mind.

How do you access the headless service in the import cluster, through the domain name?
If there are two exported clusters, the endpoint obtained through domain name resolution should have two my-service-0, how do you solve this problem?

wenchezhao · 2023-04-10T10:17:12Z

How do you access the headless service in the import cluster, through the domain name? If there are two exported clusters, the endpoint obtained through domain name resolution should have two my-service-0, how do you solve this problem?

@XiShanYongYe-Chang yes, through the domain name. that’s exactly what I want to do next. I plan to write a coredns plugin to solve related problems.

XiShanYongYe-Chang · 2023-04-10T12:51:18Z

@XiShanYongYe-Chang yes, through the domain name. that’s exactly what I want to do next.

Thanks for you confirm.

I plan to write a coredns plugin to solve related problems.

Would you mind creating a new issue to track this task? And I'm interested in it, we can continue to discuss the solution.

XiShanYongYe-Chang

Generally LGTM, can you help squash the commits into one?

wenchezhao · 2023-04-11T01:10:29Z

Would you mind creating a new issue to track this task? And I'm interested in it, we can continue to discuss the solution.

ok, no problem.

wenchezhao · 2023-04-11T01:13:29Z

squash the commits into one?

why squash the commits into one?I think these are two separate things, so I deliberately submitted them in two separate times.

XiShanYongYe-Chang · 2023-04-11T01:23:54Z

I understand why you set two commits. Currently, the new label does not seem to be used. Personally, a single commit may be confusing.

Signed-off-by: wenche <wenchuan.zhao@qq.com>

wenchezhao · 2023-04-11T05:48:07Z

I understand why you set two commits. Currently, the new label does not seem to be used. Personally, a single commit may be confusing.

I have already made the changes.

XiShanYongYe-Chang · 2023-04-12T09:22:06Z

I have already made the changes.

Thanks~

@RainbowMango Can you help rerun the e2e. I'm modifying the incorrect case.

RainbowMango · 2023-04-12T10:24:02Z

Done.

XiShanYongYe-Chang · 2023-04-14T08:53:31Z

/lgtm
/approve
/cc @RainbowMango

karmada-bot · 2023-04-14T08:53:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XiShanYongYe-Chang
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango

/assign

RainbowMango · 2023-04-18T01:25:09Z

@chaunceyjiang Do you have any comments?

chaunceyjiang · 2023-04-18T02:00:50Z

Just a suggestion, can we contribute this patch to upstream? See what upstream has to say about this patch.

RainbowMango · 2023-04-18T06:47:10Z

Just a suggestion, can we contribute this patch to upstream? See what upstream has to say about this patch.

Yes, we can talk about it with upstream guys. But, what's your opinion?

chaunceyjiang · 2023-04-18T06:57:26Z

My point is to let this pr wait for a while, the next release version of Karmada still has a long time. We can discuss clearly in the upstream before deciding whether to merge this pr.

chaunceyjiang · 2023-04-18T06:59:21Z

My core thought is that MCS should be consistent with upstream.

karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 7, 2023

karmada-bot requested review from chaunceyjiang and Garrybest April 7, 2023 03:46

karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2023

wenchezhao force-pushed the mcs-headless-svc branch from c98ec5f to b1fbec5 Compare April 7, 2023 05:45

RainbowMango reviewed Apr 10, 2023

View reviewed changes

karmada-bot assigned XiShanYongYe-Chang Apr 10, 2023

XiShanYongYe-Chang reviewed Apr 10, 2023

View reviewed changes

enable mcs to support headless-svc

313065f

Signed-off-by: wenche <wenchuan.zhao@qq.com>

wenchezhao force-pushed the mcs-headless-svc branch from b1fbec5 to 313065f Compare April 11, 2023 05:44

karmada-bot requested a review from RainbowMango April 14, 2023 08:53

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023

RainbowMango reviewed Apr 17, 2023

View reviewed changes

karmada-bot assigned RainbowMango Apr 17, 2023

liangyuanpeng mentioned this pull request Sep 25, 2023

[Question] Deploying resources that need inter-cluster communitation #4077

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable mcs to support headless-svc #3372

enable mcs to support headless-svc #3372

wenchezhao commented Apr 7, 2023

chaunceyjiang commented Apr 7, 2023

codecov-commenter commented Apr 7, 2023 •

edited

wenchezhao commented Apr 7, 2023

XiShanYongYe-Chang commented Apr 7, 2023

wenchezhao commented Apr 7, 2023

RainbowMango left a comment

XiShanYongYe-Chang commented Apr 10, 2023

wenchezhao commented Apr 10, 2023 •

edited

XiShanYongYe-Chang commented Apr 10, 2023

wenchezhao commented Apr 10, 2023

XiShanYongYe-Chang commented Apr 10, 2023

wenchezhao commented Apr 10, 2023

XiShanYongYe-Chang commented Apr 10, 2023

XiShanYongYe-Chang left a comment

wenchezhao commented Apr 11, 2023

wenchezhao commented Apr 11, 2023

XiShanYongYe-Chang commented Apr 11, 2023

wenchezhao commented Apr 11, 2023

XiShanYongYe-Chang commented Apr 12, 2023

RainbowMango commented Apr 12, 2023

XiShanYongYe-Chang commented Apr 14, 2023

karmada-bot commented Apr 14, 2023

RainbowMango left a comment

RainbowMango commented Apr 18, 2023

chaunceyjiang commented Apr 18, 2023

RainbowMango commented Apr 18, 2023

chaunceyjiang commented Apr 18, 2023

chaunceyjiang commented Apr 18, 2023

enable mcs to support headless-svc #3372

Are you sure you want to change the base?

enable mcs to support headless-svc #3372

Conversation

wenchezhao commented Apr 7, 2023

chaunceyjiang commented Apr 7, 2023

codecov-commenter commented Apr 7, 2023 • edited

Codecov Report

wenchezhao commented Apr 7, 2023

XiShanYongYe-Chang commented Apr 7, 2023

wenchezhao commented Apr 7, 2023

RainbowMango left a comment

Choose a reason for hiding this comment

XiShanYongYe-Chang commented Apr 10, 2023

wenchezhao commented Apr 10, 2023 • edited

XiShanYongYe-Chang commented Apr 10, 2023

wenchezhao commented Apr 10, 2023

XiShanYongYe-Chang commented Apr 10, 2023

wenchezhao commented Apr 10, 2023

XiShanYongYe-Chang commented Apr 10, 2023

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

wenchezhao commented Apr 11, 2023

wenchezhao commented Apr 11, 2023

XiShanYongYe-Chang commented Apr 11, 2023

wenchezhao commented Apr 11, 2023

XiShanYongYe-Chang commented Apr 12, 2023

RainbowMango commented Apr 12, 2023

XiShanYongYe-Chang commented Apr 14, 2023

karmada-bot commented Apr 14, 2023

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango commented Apr 18, 2023

chaunceyjiang commented Apr 18, 2023

RainbowMango commented Apr 18, 2023

chaunceyjiang commented Apr 18, 2023

chaunceyjiang commented Apr 18, 2023

codecov-commenter commented Apr 7, 2023 •

edited

wenchezhao commented Apr 10, 2023 •

edited