-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the helmrealesa name prefix to the external etcd secret #3530
Add the helmrealesa name prefix to the external etcd secret #3530
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3530 +/- ##
==========================================
+ Coverage 52.75% 52.96% +0.21%
==========================================
Files 214 216 +2
Lines 19799 20014 +215
==========================================
+ Hits 10445 10601 +156
- Misses 8789 8843 +54
- Partials 565 570 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
72de0ac
to
8615ea5
Compare
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Poor12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
8615ea5
to
fc43ffa
Compare
/lgtm |
What type of PR is this?
kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # #3528
Special notes for your reviewer:
Does this PR introduce a user-facing change?: