Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the helmrealesa name prefix to the external etcd secret #3530

Conversation

learner0810
Copy link
Member

@learner0810 learner0810 commented May 12, 2023

What type of PR is this?
kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes # #3528

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #3530 (fc43ffa) into master (e56beda) will increase coverage by 0.21%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3530      +/-   ##
==========================================
+ Coverage   52.75%   52.96%   +0.21%     
==========================================
  Files         214      216       +2     
  Lines       19799    20014     +215     
==========================================
+ Hits        10445    10601     +156     
- Misses       8789     8843      +54     
- Partials      565      570       +5     
Flag Coverage Δ
unittests 52.96% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@learner0810 learner0810 force-pushed the add-helm-releasename-name-prefix-to-external-etcd-secret branch 3 times, most recently from 72de0ac to 8615ea5 Compare May 16, 2023 02:43
@calvin0327
Copy link

LGTM
@Poor12 cc

@Poor12
Copy link
Member

Poor12 commented May 16, 2023

/approve
Leave LGTM to @calvin0327

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poor12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
@learner0810 learner0810 force-pushed the add-helm-releasename-name-prefix-to-external-etcd-secret branch from 8615ea5 to fc43ffa Compare May 16, 2023 06:07
@calvin0327
Copy link

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@karmada-bot karmada-bot merged commit 15a9a26 into karmada-io:master May 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants