Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #3618

Merged
merged 1 commit into from
Jun 2, 2023
Merged

fix typos #3618

merged 1 commit into from
Jun 2, 2023

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?
/kind cleanup
fix typos

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 1, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #3618 (417423f) into master (8b4703e) will decrease coverage by 0.66%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3618      +/-   ##
==========================================
- Coverage   55.86%   55.20%   -0.66%     
==========================================
  Files         216      221       +5     
  Lines       20121    20831     +710     
==========================================
+ Hits        11240    11500     +260     
- Misses       8276     8721     +445     
- Partials      605      610       +5     
Flag Coverage Δ
unittests 55.20% <ø> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/karmadactl/cmdinit/cert/cert.go 48.01% <ø> (ø)

... and 17 files with indirect coverage changes

@Vacant2333
Copy link
Contributor Author

/assign @RainbowMango

Copy link
Member

@Poor12 Poor12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting!

operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
operator/pkg/apis/operator/v1alpha1/type.go Outdated Show resolved Hide resolved
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please help to squash-commits, then we are ready to go.

ROADMAP.md Show resolved Hide resolved
Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Poor12
Do you have any other comments?

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@Poor12
Copy link
Member

Poor12 commented Jun 2, 2023

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@karmada-bot karmada-bot merged commit 1251ec9 into karmada-io:master Jun 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants