New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add printcolumn for FederatedHPA #3622
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3622 +/- ##
=======================================
Coverage 55.22% 55.22%
=======================================
Files 221 221
Lines 20831 20831
=======================================
Hits 11504 11504
Misses 8717 8717
Partials 610 610
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Poor12 <shentiecheng@huawei.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
Please update the PR description according to the latest content.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Add printcolumn for FederatedHPA
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Add printcolumn for FederatedHPA
Unlike the native HPA, FederatedHPA cannot print the target utilization as the limit of CRD. As far as I know, CRD‘s print column only supports definite json path.
The native hpa is like:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: