Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add printcolumn for FederatedHPA #3622

Merged
merged 1 commit into from Jun 4, 2023
Merged

Conversation

Poor12
Copy link
Member

@Poor12 Poor12 commented Jun 2, 2023

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Add printcolumn for FederatedHPA

NAME         REFERENCE-KIND   REFERENCE-NAME   MINPODS   MAXPODS   REPLICAS   AGE
nginx-test   Deployment       nginx            1         10        1          5d1h

Unlike the native HPA, FederatedHPA cannot print the target utilization as the limit of CRD. As far as I know, CRD‘s print column only supports definite json path.

The native hpa is like:

NAME         REFERENCE          TARGETS        MINPODS   MAXPODS   REPLICAS   AGE
nginx-test   Deployment/nginx   <unknown>/10   1         10        0          3h59m

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

api-change:  add printcolumn for `FederatedHPA`, including reference, minpods, maxpods and replicas.

@karmada-bot karmada-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 2, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2023
@Poor12 Poor12 marked this pull request as ready for review June 2, 2023 03:29
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3622 (b0dbb9f) into master (cf46126) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3622   +/-   ##
=======================================
  Coverage   55.22%   55.22%           
=======================================
  Files         221      221           
  Lines       20831    20831           
=======================================
  Hits        11504    11504           
  Misses       8717     8717           
  Partials      610      610           
Flag Coverage Δ
unittests 55.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2023
Signed-off-by: Poor12 <shentiecheng@huawei.com>
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2023
@jwcesign
Copy link
Member

jwcesign commented Jun 4, 2023

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold
Please update the PR description according to the latest content.

@karmada-bot karmada-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2023
@Poor12
Copy link
Member Author

Poor12 commented Jun 4, 2023

/approve

/hold Please update the PR description according to the latest content.

Done.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2023
@karmada-bot karmada-bot merged commit bfb9bc3 into karmada-io:master Jun 4, 2023
10 checks passed
jwcesign pushed a commit to jwcesign/karmada that referenced this pull request Jun 8, 2023
Add printcolumn for FederatedHPA
@RainbowMango RainbowMango added this to the v1.7 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants