Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop update-krew for release-1.5.x #3629

Merged

Conversation

yike21
Copy link
Member

@yike21 yike21 commented Jun 3, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove update-krew-index from branch release-1.5.

Which issue(s) this PR fixes:
Fixes #3624

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: yike21 <yike21@qq.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 3, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3629 (0f210cd) into release-1.5 (11fac25) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           release-1.5    #3629   +/-   ##
============================================
  Coverage        49.17%   49.17%           
============================================
  Files              203      203           
  Lines            18514    18514           
============================================
  Hits              9105     9105           
  Misses            8912     8912           
  Partials           497      497           
Flag Coverage Δ
unittests 49.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2023
@RainbowMango
Copy link
Member

Awesome @yike21 !

@karmada-bot karmada-bot merged commit 9e9ffb9 into karmada-io:release-1.5 Jun 4, 2023
12 checks passed
@yike21
Copy link
Member Author

yike21 commented Jun 4, 2023

Thanks!

@yike21 yike21 deleted the pr_stop_update_krew_for15 branch June 4, 2023 01:50
@RainbowMango
Copy link
Member

Hi @yike21 , you are welcome to become a member, you've made a significant contributions to the community, you deserve it.

@yike21
Copy link
Member Author

yike21 commented Jun 4, 2023

Hi @yike21 , you are welcome to become a member, you've made a significant contributions to the community, you deserve it.

Thank you so much for the encouragement! I'd be happy to be a part of the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants