Add proposal for remove derived mcs #3705
Conversation
karmada-bot
added
do-not-merge/contains-merge-commits
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3705 +/- ##
==========================================
- Coverage 55.69% 55.68% -0.02%
==========================================
Files 222 225 +3
Lines 21195 21313 +118
==========================================
+ Hits 11805 11868 +63
- Misses 8763 8813 +50
- Partials 627 632 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
zishen
force-pushed
the
remove-derived-mcs
branch
from
54aafd9
to
6712eae
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
zishen
force-pushed
the
remove-derived-mcs
branch
2 times, most recently
from
40a14bb
to
800021a
Compare
zishen
force-pushed
the
remove-derived-mcs
branch
from
800021a
to
21053bc
Compare
zishen
force-pushed
the
remove-derived-mcs
branch
3 times, most recently
from
d69ad0a
to
c21dbb0
Compare
| The workflow of the additional dnsvserver as follows: | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
This is no image showing here:
There was a problem hiding this comment.
This is no image showing here:
oh， it's ok in my brower. I think you need a pull, for this is l just up recently.
|
|
||
| 1. Load balancing can be achieved. Since the extended dns resolver is customized, customers can achieve load balancing here. | ||
|
|
||
| 2. Access in the original way can be realized. Rules for local services and remote services can be determined in custom plug-ins. Therefore, the original access method can be maintained, in this case is `foo.default.svc.cluster.local`. |
There was a problem hiding this comment.
How can achieve this point? How to distinguish the single-cluster service or multi-cluster service?
There was a problem hiding this comment.
How can achieve this point? How to distinguish the single-cluster service or multi-cluster service?
I mean it's all up to the user to customize the development, so there's a lot of flexibility.
|
|
||
| #### coredns compile | ||
|
|
||
| Refer to [Compile Instructions](#Compilation Instructions). |
There was a problem hiding this comment.
This is the difference between github and typora. Let me find a solution
|
|
||
| #### coredns configuration | ||
|
|
||
| Refer to [Configuration Description](#Configuration Description). |
| ### Test Plan | ||
|
|
||
| - All current testing should be passed, no break change would be involved by this feature. | ||
| - Add new E2E tests to cover the feature, the scope should include: |
There was a problem hiding this comment.
E2E testing is not easy to add, right?
There was a problem hiding this comment.
Yes, it's difficult. I haven't figured it out yet.
zishen
force-pushed
the
remove-derived-mcs
branch
from
c21dbb0
to
c49894a
Compare
karmada-bot
added
the
do-not-merge/contains-merge-commits
zishen
force-pushed
the
remove-derived-mcs
branch
from
c49894a
to
c88bd18
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
zishen
force-pushed
the
remove-derived-mcs
branch
4 times, most recently
from
9674338
to
b1ab179
Compare
Signed-off-by: Tanggui Bian <softwarebtg@163.com>
zishen
force-pushed
the
remove-derived-mcs
branch
from
b1ab179
to
7f72c0d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind design
Which issue(s) this PR fixes:
Fixes issue-2384