Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e coverage details #3767

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?
Add features e2e test coverage details
issue:#3685

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Vacant2333 <vacant2333@gmail.com>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Vacant2333 Vacant2333 changed the title add e2e coverage details [WIP] add e2e coverage details Jul 5, 2023
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #3767 (205d041) into master (76d0517) will decrease coverage by 0.98%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3767      +/-   ##
==========================================
- Coverage   56.61%   55.63%   -0.98%     
==========================================
  Files         221      224       +3     
  Lines       20831    21255     +424     
==========================================
+ Hits        11793    11826      +33     
- Misses       8414     8797     +383     
- Partials      624      632       +8     
Flag Coverage Δ
unittests 55.63% <ø> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vacant2333 thanks~
Is this a template, for each feature, its E2E test coverage and Coverage details will look like in the future, can you give a simple example?

@Vacant2333
Copy link
Contributor Author

Hi @Vacant2333 thanks~ Is this a template, for each feature, its E2E test coverage and Coverage details will look like in the future, can you give a simple example?

hi ,yes its a template now, im working on it now and add details

Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
@Vacant2333 Vacant2333 changed the title [WIP] add e2e coverage details add e2e coverage details Jul 5, 2023
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@XiShanYongYe-Chang
Copy link
Member

hi ,yes its a template now, im working on it now and add details

Ok, I get it.

@Vacant2333
Copy link
Contributor Author

hi ,yes its a template now, im working on it now and add details

Ok, I get it.

I have organized the e2e tests of Karmada, but I may not have sufficient understanding of most of the features. I need further review and suggestions.

## Cross-cloud multi-cluster multi-mode management
| Feature | E2E test coverage | Coverage details |
|-----------------------|-------------------|------------------------------------------------------------------------------|
| Safe isolation | Yes | https://github.com/karmada-io/karmada/blob/master/test/e2e/namespace_test.go |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file position changes, this link will be invalid. Do we really need this information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes its a question, but more infomations are good for this, is there another way to show the files?

@Vacant2333 Vacant2333 closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants