-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e coverage details #3767
add e2e coverage details #3767
Conversation
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3767 +/- ##
==========================================
- Coverage 56.61% 55.63% -0.98%
==========================================
Files 221 224 +3
Lines 20831 21255 +424
==========================================
+ Hits 11793 11826 +33
- Misses 8414 8797 +383
- Partials 624 632 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Vacant2333 thanks~
Is this a template, for each feature, its E2E test coverage
and Coverage details
will look like in the future, can you give a simple example?
hi ,yes its a template now, im working on it now and add details |
Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
Ok, I get it. |
I have organized the e2e tests of Karmada, but I may not have sufficient understanding of most of the features. I need further review and suggestions. |
## Cross-cloud multi-cluster multi-mode management | ||
| Feature | E2E test coverage | Coverage details | | ||
|-----------------------|-------------------|------------------------------------------------------------------------------| | ||
| Safe isolation | Yes | https://github.com/karmada-io/karmada/blob/master/test/e2e/namespace_test.go | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the file position changes, this link will be invalid. Do we really need this information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes its a question, but more infomations are good for this, is there another way to show the files?
What type of PR is this?
Add features e2e test coverage details
issue:#3685
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: