Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: seamless cluster migration #3780

Merged
merged 1 commit into from
Jul 23, 2023
Merged

proposal: seamless cluster migration #3780

merged 1 commit into from
Jul 23, 2023

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?
/kind design
/kind documentation

What this PR does / why we need it:
seamless cluster migration proposal.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

added a string type filed into the API of PropagationPolicy、ResourceBinding and Work, which is aim to indicate how to take over a matching resource when there is a conflict in the member cluster.

@karmada-bot karmada-bot added the kind/design Categorizes issue or PR as related to design. label Jul 10, 2023
@karmada-bot karmada-bot added kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023 •
edited

Codecov Report

Merging #3780 (d782068) into master (355b52c) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3780      +/-   ##
==========================================
- Coverage   55.70%   55.69%   -0.01%     
==========================================
  Files         224      224              
  Lines       21283    21283              
==========================================
- Hits        11856    11854       -2     
- Misses       8796     8797       +1     
- Partials      631      632       +1
Flag Coverage Δ
unittests 55.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@chaosi-zju chaosi-zju force-pushed the migration branch 4 times, most recently from ac0029c to 8cebf71 Compare July 10, 2023 12:17
RainbowMango
RainbowMango reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is on going.
Posting it as you just refreshed the content and I can't apply more comments in this context.

docs/proposals/migration/design-of-seamless-cluster-migration-scheme.md Outdated Show resolved Hide resolved
docs/proposals/migration/design-of-seamless-cluster-migration-scheme.md Outdated Show resolved Hide resolved
docs/proposals/migration/design-of-seamless-cluster-migration-scheme.md Outdated Show resolved Hide resolved
docs/proposals/migration/design-of-seamless-cluster-migration-scheme.md Outdated Show resolved Hide resolved
whitewindmills
whitewindmills reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@whitewindmills whitewindmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good proposal

docs/proposals/migration/design-of-seamless-cluster-migration-scheme.md Outdated Show resolved Hide resolved
docs/proposals/migration/design-of-seamless-cluster-migration-scheme.md Outdated Show resolved Hide resolved
docs/proposals/migration/design-of-seamless-cluster-migration-scheme.md Outdated Show resolved Hide resolved
@chaosi-zju chaosi-zju force-pushed the migration branch 5 times, most recently from 3c52f11 to 307444e Compare July 18, 2023 05:38
@yizhang-zen yizhang-zen mentioned this pull request Jul 18, 2023
Closed
@chaosi-zju chaosi-zju force-pushed the migration branch 2 times, most recently from f1e867e to c7fe47d Compare July 18, 2023 08:30
@karmada-bot karmada-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2023
@chaosi-zju chaosi-zju force-pushed the migration branch 2 times, most recently from ba99202 to d8b6146 Compare July 19, 2023 03:26
@chaunceyjiang
Copy link
Member

This is a good proposal.

@RainbowMango RainbowMango mentioned this pull request Jul 19, 2023
Merged
@RainbowMango
Copy link
Member

Hey folks, I just sent a PR taking the API part of this proposal, Please take a look.

@chaosi-zju chaosi-zju mentioned this pull request Jul 20, 2023
Merged
@chaosi-zju
Copy link
Member Author

chaosi-zju commented Jul 21, 2023 •
edited

Do you have any further comments? If you have any other suggestions, please let me know.

@RainbowMango @chaunceyjiang @whitewindmills @Tingtal @XiShanYongYe-Chang

@chaosi-zju
Copy link
Member Author

Hey folks, I just sent a PR taking the API part of this proposal, Please take a look.

feature realization PR: #3821

@XiShanYongYe-Chang
Copy link
Member

feature realization PR: #3821

How about creating an issue to track all related activities?

@chaosi-zju chaosi-zju mentioned this pull request Jul 21, 2023
Closed
@chaosi-zju
Copy link
Member Author

feature realization PR: #3821

How about creating an issue to track all related activities?

done, #3824

@chaosi-zju
Added proposal about seamless cluster migration
876c85c 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
RainbowMango
RainbowMango approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2023
@karmada-bot karmada-bot merged commit c3164f2 into karmada-io:master Jul 23, 2023
12 checks passed
@RainbowMango RainbowMango added this to the v1.7 milestone Jul 26, 2023
@chaosi-zju chaosi-zju mentioned this pull request Aug 16, 2023
Closed
8 tasks
@zishen zishen mentioned this pull request Aug 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zishen zishen zishen left review comments

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@jwcesign jwcesign jwcesign left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@whitewindmills whitewindmills whitewindmills left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Tingtal Tingtal Awaiting requested review from Tingtal

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@chaosi-zju @codecov-commenter @chaunceyjiang @RainbowMango @XiShanYongYe-Chang @karmada-bot @zishen @jwcesign @whitewindmills