Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proposal for cluster proxy enhancement #3822

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jwcesign
Copy link
Member

What type of PR is this?
/kind design
/kind documentation

What this PR does / why we need it:
The single cluster users usually use kubectl to query resources from member clusters separately. So after migrating to Karmada with multiple clusters, it will be great if they still can use kubectl to query resources from member clusters and unaware the member clusters, maintain the same experience as when in a cluster.

Also, Karmada is usually used in multi-tenant environment, user A cloud not access to the resource of user B. This is always achieved by using RBAC. Which means the query operation should follow the RBAC privilege limitations in member clusters.

So this proposal proposes an enhancement to query resources from member clusters with native kubectl, unaware the member clusters, and follow RBAC privilege limitations in member clusters.

With this enhancement, users can feel the lease changes after migrating to Karmada, but enjoy the benefits of multiple clusters.

Which issue(s) this PR fixes:
Fixes #none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 20, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2023
@jwcesign jwcesign force-pushed the proposal-cluster-proxy branch 2 times, most recently from 3f4be5b to b305d4a Compare July 21, 2023 01:38
Signed-off-by: jwcesign <jwcesign@gmail.com>
@jwcesign
Copy link
Member Author

@karmada-bot
Copy link
Collaborator

@jwcesign: GitHub didn't allow me to request PR reviews from the following users: yizhang-zen.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @XiShanYongYe-Chang @GitHubxsy @yizhang-zen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This might be a good place to talk about core concepts and how they relate.
-->

- If there are resources with the same name in different member clusters, operations such as `get`, `describe`, `exec`, and `logs` will fail.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add a external parameter like "--c clustername' to specify the cluster? If not point the multiple resource objects confusion .

Comment on lines +164 to +165
1. Query target resource from all the clusters with the account of `kubeconfig`, and find out the only one target cluster.
2. Route the request to the target cluster with the account of `kubeconfig`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which kubeconfig we are talking about here? Karmada's kubeconfig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants