Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add e2e test for seamless migration #3838

Merged
merged 1 commit into from
Jul 29, 2023
Merged

test: add e2e test for seamless migration #3838

merged 1 commit into from
Jul 29, 2023

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add e2e test for #3821

Which issue(s) this PR fixes:
Fixes #3824

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
none

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 25, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 25, 2023
@chaosi-zju chaosi-zju mentioned this pull request Jul 25, 2023
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #3838 (d4b57b8) into master (6ef427a) will increase coverage by 0.04%.
The diff coverage is 61.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3838      +/-   ##
==========================================
+ Coverage   55.50%   55.54%   +0.04%     
==========================================
  Files         226      226              
  Lines       21457    21507      +50     
==========================================
+ Hits        11910    11947      +37     
- Misses       8911     8924      +13     
  Partials      636      636
Flag Coverage Δ
unittests 55.54% <61.70%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/detector/detector.go 0.00% <0.00%> (ø)
pkg/util/helper/work.go 41.28% <0.00%> (-1.17%) ⬇️
pkg/controllers/binding/common.go 45.56% <91.66%> (+7.63%) ⬆️
pkg/util/annotation.go 96.36% <100.00%> (+0.53%) ⬆️

... and 2 files with indirect coverage changes

@chaosi-zju chaosi-zju force-pushed the migration-e2e branch 3 times, most recently from 3f934d3 to 0b5631b Compare July 26, 2023 01:10
@XiShanYongYe-Chang
Copy link
Member

I would like to invite @yike21, @Vacant2333, and @zhy76 to come and help take a look.
/cc @yike21 @Vacant2333 @zhy76

@karmada-bot karmada-bot requested a review from yike21 July 26, 2023 01:19
@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: Vacant2333, zhy76.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

I would like to invite @yike21, @Vacant2333, and @zhy76 to come and help take a look.
/cc @yike21 @Vacant2333 @zhy76

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Vacant2333
Copy link
Contributor

ok, i will take a look

@zhy76
Copy link
Member

zhy76 commented Jul 26, 2023

I would like to invite @yike21, @Vacant2333, and @zhy76 to come and help take a look. /cc @yike21 @Vacant2333 @zhy76

OK

Vacant2333
Vacant2333 suggested changes Jul 26, 2023
View reviewed changes
test/e2e/seamless_migration_test.go Outdated Show resolved Hide resolved
@yike21
Copy link
Member

yike21 commented Jul 26, 2023

I would like to invite @yike21, @Vacant2333, and @zhy76 to come and help take a look. /cc @yike21 @Vacant2333 @zhy76

OK, I will take a look

@chaosi-zju chaosi-zju force-pushed the migration-e2e branch 2 times, most recently from 8d968ab to 139832d Compare July 26, 2023 08:11
@chaosi-zju chaosi-zju mentioned this pull request Jul 26, 2023
Merged
yike21
yike21 reviewed Jul 27, 2023
View reviewed changes
test/e2e/seamless_migration_test.go Outdated Show resolved Hide resolved
test/e2e/seamless_migration_test.go Outdated Show resolved Hide resolved
test/e2e/seamless_migration_test.go Outdated Show resolved Hide resolved
test/e2e/seamless_migration_test.go Outdated Show resolved Hide resolved
@yike21
Copy link
Member

yike21 commented Jul 27, 2023

LGTM
Please help to see what other optimisations are possible. /cc @Vacant2333 @zhy76

@zhy76
Copy link
Member

zhy76 commented Jul 28, 2023

LGTM

@chaosi-zju chaosi-zju force-pushed the migration-e2e branch 2 times, most recently from 2068814 to 411ff08 Compare July 28, 2023 10:33
@Vacant2333
Copy link
Contributor

lgtm

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jul 29, 2023
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为将来用户的环境上可能没有一个叫做member1的集群

@XiShanYongYe-Chang
Copy link
Member

@yike21 @zhy76 @Vacant2333 Thanks all of you 👍

@chaosi-zju chaosi-zju force-pushed the migration-e2e branch 2 times, most recently from 9efde39 to 0166cc2 Compare July 29, 2023 04:22
@chaosi-zju
test: add e2e test for seamless migration.
3026fc7 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@XiShanYongYe-Chang
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vacant2333, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2023
@karmada-bot karmada-bot merged commit fe0fc02 into karmada-io:master Jul 29, 2023
12 checks passed
@chaosi-zju chaosi-zju mentioned this pull request Aug 16, 2023
Closed
8 tasks
@Vacant2333 Vacant2333 mentioned this pull request Aug 22, 2023
Closed
8 tasks
@zhy76 zhy76 mentioned this pull request Nov 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yike21 yike21 yike21 left review comments

@zhy76 zhy76 zhy76 left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@Vacant2333 Vacant2333 Vacant2333 approved these changes

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Achieve seamless migrate resource from existing clusters to Karmada
7 participants
@chaosi-zju @codecov-commenter @XiShanYongYe-Chang @karmada-bot @Vacant2333 @zhy76 @yike21