-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add label on the namespace created by karmada #3839
Conversation
3f9faff
to
7cf3aed
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3839 +/- ##
==========================================
+ Coverage 55.17% 55.22% +0.04%
==========================================
Files 227 227
Lines 21653 21666 +13
==========================================
+ Hits 11948 11965 +17
+ Misses 9069 9065 -4
Partials 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
/lgtm
/kind feature Can you help update the release note:
|
OK |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
Signed-off-by: zhy76 <958474674@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So quick response.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2862
Special notes for your reviewer:
![1690297085554_55BC3EBF-9367-464a-AFF4-5A101499EB30](https://private-user-images.githubusercontent.com/56665618/255959070-0b37dcb0-9fdd-43ae-8f34-c4cd66f5b5fa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODI5NzMsIm5iZiI6MTcxOTk4MjY3MywicGF0aCI6Ii81NjY2NTYxOC8yNTU5NTkwNzAtMGIzN2RjYjAtOWZkZC00M2FlLThmMzQtYzRjZDY2ZjViNWZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA0NTc1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRiODI5YzgxNTFmMjQ5NTZlYjBiMGZiZDg0N2IzNDY2NTNlMTBjNjBmNGYxMDhmNjBhMTFkMWNlYjA0OTg2ZGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9steLN-MJKEKYycZs2SkIMTiFSZGCOPLZ9t2Y9vaCjY)
when adding a cluster to karmada, it will has a label indicating that the namespace was created by karmada to avoid accidental deletion.:
Does this PR introduce a user-facing change?: