Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add label on the namespace created by karmada #3839

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

zhy76
Copy link
Member

@zhy76 zhy76 commented Jul 25, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #2862

Special notes for your reviewer:
when adding a cluster to karmada, it will has a label indicating that the namespace was created by karmada to avoid accidental deletion.:
1690297085554_55BC3EBF-9367-464a-AFF4-5A101499EB30

Does this PR introduce a user-facing change?:

karmadactl join/register, karmada-agent: Add labels on the namespace created by karmada.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@zhy76 zhy76 force-pushed the label branch 2 times, most recently from 3f9faff to 7cf3aed Compare July 25, 2023 17:33
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #3839 (8c25212) into master (2526de8) will increase coverage by 0.04%.
Report is 2 commits behind head on master.
The diff coverage is 87.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
+ Coverage   55.17%   55.22%   +0.04%     
==========================================
  Files         227      227              
  Lines       21653    21666      +13     
==========================================
+ Hits        11948    11965      +17     
+ Misses       9069     9065       -4     
  Partials      636      636              
Flag Coverage Δ
unittests 55.22% <87.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/util/credential.go 65.28% <80.00%> (+2.45%) ⬆️
pkg/util/namespace.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@XiShanYongYe-Chang
Copy link
Member

/kind feature

Can you help update the release note:

karmadactl join/register, karmada-agent: Add labels on the namespace created by karmada.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2023
@zhy76
Copy link
Member Author

zhy76 commented Jul 26, 2023

/kind feature

Can you help update the release note:

karmadactl join/register, karmada-agent: Add labels on the namespace created by karmada.

OK

@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2023
@whitewindmills
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

pkg/util/namespace.go Outdated Show resolved Hide resolved
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

pkg/util/namespace.go Show resolved Hide resolved
pkg/util/namespace_test.go Show resolved Hide resolved
Signed-off-by: zhy76 <958474674@qq.com>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So quick response.
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2023
@karmada-bot karmada-bot merged commit ee3fa49 into karmada-io:master Jul 29, 2023
12 checks passed
@zhy76 zhy76 deleted the label branch July 29, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels on the namespace created by karmada
6 participants