Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Golang version from v1.20.4 to v1.20.6 #3865

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

parthn2
Copy link
Contributor

@parthn2 parthn2 commented Jul 31, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates the default Go version for CI and release bots to v1.20.6.s

Which issue(s) this PR fixes:
Fixes #3864

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada(v1.7) is now built with Go1.20.6.

Signed-off-by: Parth Nanda <parthnanda002@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 31, 2023
@karmada-bot
Copy link
Collaborator

Welcome @parthn2! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3865 (5ffead8) into master (4488898) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3865   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files         227      227           
  Lines       21676    21676           
=======================================
+ Hits        11911    11912    +1     
+ Misses       9126     9125    -1     
  Partials      639      639           
Flag Coverage Δ
unittests 54.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @parthn2 and welcome to Karmada~

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@karmada-bot karmada-bot merged commit 09259b1 into karmada-io:master Jul 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Golang version from v1.20.4 to v1.20.6
4 participants