-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ClusterCacheSyncTimeout for resources on fed control plane as well #3874
use ClusterCacheSyncTimeout for resources on fed control plane as well #3874
Conversation
Signed-off-by: lxtywypc <lxtywypc@gmail.com>
5d6df18
to
fad172d
Compare
@@ -68,6 +68,7 @@ type FederatedHPAController struct { | |||
RESTMapper meta.RESTMapper | |||
EventRecorder record.EventRecorder | |||
TypedInformerManager typedmanager.MultiClusterInformerManager | |||
ClusterCacheSyncTimeout metav1.Duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, 100% agree that we need to use the same configuration for informers inside of a controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @lxtywypc .
I updated the release notes a little bit by the way.
I also revisited the #1112, thanks @snowplayfire for introducing the flag. It means a lot to Karmada's scalability.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's useful , let me cherry pick it to 1.6 |
We don't usually cherry-pick features, but considering the severity of this issue(and the fact that you have done it #3880 :)), I'm ok with it. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Now, the default timeout for waiting cache syncing in
controller-runtime
is 2 minutes. If we have a lot resources on the fed control plane, the default timeout might be reached and the process would return with an error like:And the
karmada-controller-manager
would be hard to restart successfully.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The log printed above is from
karmada-controller-manager v1.3.1
, but it still exists in the latest version.Does this PR introduce a user-facing change?: