Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e coverage analysis #3928

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Vacant2333
Copy link
Contributor

What this PR does / why we need it:
Add features e2e test coverage details
issue: #3685

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@Vacant2333 Vacant2333 changed the title Add e2e coverage analisis Add e2e coverage analysis Aug 10, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #3928 (c1d82ba) into master (37cee8d) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3928      +/-   ##
==========================================
- Coverage   54.72%   54.71%   -0.02%     
==========================================
  Files         229      229              
  Lines       22065    22074       +9     
==========================================
+ Hits        12076    12077       +1     
- Misses       9343     9351       +8     
  Partials      646      646              
Flag Coverage Δ
unittests 54.71% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/assign

test/e2e/aggregatedapi_test.go Outdated Show resolved Hide resolved
test/e2e/coverage_docs/aggregatedapi_test.md Outdated Show resolved Hide resolved
test/e2e/coverage_docs/spread_by_region_test.md Outdated Show resolved Hide resolved
test/e2e/spread_by_region_test.go Show resolved Hide resolved
Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@XiShanYongYe-Chang
Copy link
Member

/kind cleanup

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 11, 2023
@karmada-bot karmada-bot merged commit 6dea121 into karmada-io:master Aug 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants