Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic modify image version in helm chart when releasing #3931

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind flake

What this PR does / why we need it:
automatic modify image version in helm chart when releasing

Which issue(s) this PR fixes:
Fixes #3912

Special notes for your reviewer:
@RainbowMango @XiShanYongYe-Chang

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Aug 10, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #3931 (6246da1) into master (ddae25c) will decrease coverage by 0.01%.
Report is 14 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3931      +/-   ##
==========================================
- Coverage   54.71%   54.70%   -0.01%     
==========================================
  Files         229      229              
  Lines       22074    22074              
==========================================
- Hits        12077    12076       -1     
- Misses       9351     9352       +1     
  Partials      646      646              
Flag Coverage Δ
unittests 54.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@chaosi-zju
Copy link
Member Author

Test Report:

image

image

image

@chaosi-zju
Copy link
Member Author

all is ok~

@chaosi-zju
Copy link
Member Author

@lfbear @calvin0327 Hello, do you have any comments? If you have any suggestions, please let me know~

Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@karmada-bot karmada-bot merged commit ba1800f into karmada-io:master Aug 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

something wrong with karmada helm chart release artifacts
5 participants