feat: karmadactl init: grant clusterrole admin with karamda resource permission

[zhy76]

What type of PR is this?

What this PR does / why we need it:
feat: karmadactl init: grant clusterrole admin with karamda resource permission
Which issue(s) this PR fixes:
Part of #3916

Special notes for your reviewer:
Does this PR introduce a user-facing change?:

`karmadactl`: Granted full permissions of Karmada resources to `admin` during deployment of Karmada with `init`.

[zhy76]

How can I test locally?
I do like this:

make karmadactl
cp ./karmadactl /usr/local/bin/karmadactl
curl -L https://github.com/karmada-io/karmada/releases/download/v1.7.0-alpha.3/crds.tar.gz -o crds.tar.gz
karmadactl init --kube-image-mirror-country=cn --crds ./crds.tar.gz

but still has some problem:

[XiShanYongYe-Chang]

/cc @lonelyCZ @prodanlabs
Can you help take a look?

[codecov-commenter]

Codecov Report

Merging #3937 (90b944a) into master (54e900c) will increase coverage by 0.26%.
Report is 4 commits behind head on master.
The diff coverage is 91.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3937      +/-   ##
==========================================
+ Coverage   54.70%   54.96%   +0.26%     
==========================================
  Files         229      229              
  Lines       22074    22217     +143     
==========================================
+ Hits        12076    12212     +136     
- Misses       9352     9358       +6     
- Partials      646      647       +1     

Flag	Coverage Δ
unittests	54.96% <91.33%> (+0.26%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/karmadactl/cmdinit/karmada/deploy.go	0.00% <0.00%> (ø)
pkg/karmadactl/cmdinit/karmada/rbac.go	92.37% <95.65%> (+4.37%)	⬆️
pkg/karmadactl/cmdinit/kubernetes/deployments.go	100.00% <100.00%> (ø)
pkg/karmadactl/cmdinit/utils/rbac.go	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[lonelyCZ]

How can I test locally? I do like this:

make karmadactl
cp ./karmadactl /usr/local/bin/karmadactl
curl -L https://github.com/karmada-io/karmada/releases/download/v1.7.0-alpha.3/crds.tar.gz -o crds.tar.gz
karmadactl init --kube-image-mirror-country=cn --crds ./crds.tar.gz

but still has some problem:

It seems lack of git tag info locally. You can use git tag <version> to add a new tag and then build it.

[zhy76]

How can I test locally? I do like this:

make karmadactl
cp ./karmadactl /usr/local/bin/karmadactl
curl -L https://github.com/karmada-io/karmada/releases/download/v1.7.0-alpha.3/crds.tar.gz -o crds.tar.gz
karmadactl init --kube-image-mirror-country=cn --crds ./crds.tar.gz

but still has some problem:

It seems lack of git tag info locally. You can use git tag <version> to add a new tag and then build it.

Thanks~

[zhy76]

I have tested on my side:

git tag v1.7.0-alpha.3-60-g749f3843
hack/cli-testing-environment.sh
export KUBECONFIG="/root/karmada/karmada-apiserver.config”

karmada-edit:

karmada-view:

edit:

view:

admin:

[XiShanYongYe-Chang]

Hi @zhy76, is it ready to review?

[zhy76]

Hi @zhy76, is it ready to review?

Yes

[XiShanYongYe-Chang]

/assign

[XiShanYongYe-Chang]

Thanks~
/lgtm
/cc @lonelyCZ

[Vacant2333]

if karmadactl deinit need to delete these rbac resources?

[XiShanYongYe-Chang]

if karmadactl deinit need to delete these rbac resources?

Good question. My understanding is that when calling deinit, it will be accompanied by the removal of the Karmada control plane, and these resources will also disappear. Ask @zhy76 to help confirm this again.

[zhy76]

if karmadactl deinit need to delete these rbac resources?

Good question. My understanding is that when calling deinit, it will be accompanied by the removal of the Karmada control plane, and these resources will also disappear. Ask @zhy76 to help confirm this again.

Yes, what I understand is that the karmada control plane saves the clusterrole in karmada's etcd, and after doing deinit, karmada's etcd will be deleted, which will delete the clusterrole.

[XiShanYongYe-Chang]

/cc @lonelyCZ @RainbowMango

[XiShanYongYe-Chang]

/kind feature

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/karmadactl/cmdinit/OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment