-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add rbac task when karmada operator init #3953
Feat: Add rbac task when karmada operator init #3953
Conversation
Request a review~ 🫣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR have not finish all of the task of issue, so do not close the issue.
Thanks~ |
Ask the operator owner to help take a review. |
Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
eeb36a9
to
6dc9487
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @RainbowMango
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add karmada resource view and edit clusterrole, when karmada-operator init task
Which issue(s) this PR fixes:
Part of #3916
Special notes for your reviewer:
![image](https://private-user-images.githubusercontent.com/19872346/261965179-4bf9684e-eee1-48c1-82fd-2faa27d8f18f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NTI3NTQsIm5iZiI6MTcyMTY1MjQ1NCwicGF0aCI6Ii8xOTg3MjM0Ni8yNjE5NjUxNzktNGJmOTY4NGUtZWVlMS00OGMxLTgyZmQtMmZhYTI3ZDhmMThmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDEyNDczNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFkY2Q5NGZkMzNiZTk0MzJkZTcxOWIxOGRhMzczYjg3YTM1NzM2YTFhM2Q1NjUyNzNkNGM5YjExOWY0NGQ3MmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.OAN-xFRffLX4-nSqdqfarec0qoq9H3Hp_g5dOnggWZw)
Test:
the kubeconfig is karamda-apiserver cluster's config
Does this PR introduce a user-facing change?: