Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add rbac task when karmada operator init #3953

Conversation

Vacant2333
Copy link
Contributor

@Vacant2333 Vacant2333 commented Aug 18, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
add karmada resource view and edit clusterrole, when karmada-operator init task

Which issue(s) this PR fixes:
Part of #3916

Special notes for your reviewer:
Test:
the kubeconfig is karamda-apiserver cluster's config
image

Does this PR introduce a user-facing change?:

Add clusterrole for edit and view karmada resource when karmada-operator init

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 18, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2023
@Vacant2333
Copy link
Contributor Author

Request a review~ 🫣
/assign @lonelyCZ @XiShanYongYe-Chang

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR have not finish all of the task of issue, so do not close the issue.

operator/pkg/util/apiclient/idempotency.go Show resolved Hide resolved
operator/pkg/util/apiclient/idempotency.go Show resolved Hide resolved
@XiShanYongYe-Chang
Copy link
Member

Thanks~
/assign

@XiShanYongYe-Chang
Copy link
Member

Ask the operator owner to help take a review.
/cc @calvin0327 @Poor12 @lonelyCZ

Signed-off-by: Vacant2333 <rentian.zhou@daocloud.io>
@Vacant2333 Vacant2333 force-pushed the add_rbac_task_when_karmada_operator_init branch from eeb36a9 to 6dc9487 Compare August 21, 2023 07:44
@RainbowMango RainbowMango added this to the v1.7 milestone Aug 29, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@karmada-bot karmada-bot merged commit 9003c83 into karmada-io:master Aug 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants