Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add karmada resource clusterrole for helm install #3957

Conversation

Vacant2333
Copy link
Contributor

@Vacant2333 Vacant2333 commented Aug 19, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
add admin clusterrole for karmada resources when helm install
Which issue(s) this PR fixes:
Part of #3916

Special notes for your reviewer:
Test:
install by helm, and create the clusterroles
image

Does this PR introduce a user-facing change?:

`Chart`: Granted full permissions of Karmada resources to `admin`.

Signed-off-by: Vacant2333 <vacant2333@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3957 (fc7368c) into master (6dea121) will decrease coverage by 0.02%.
Report is 29 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
- Coverage   54.70%   54.69%   -0.02%     
==========================================
  Files         229      229              
  Lines       22074    22086      +12     
==========================================
+ Hits        12076    12080       +4     
- Misses       9352     9358       +6     
- Partials      646      648       +2     
Flag Coverage Δ
unittests 54.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@Vacant2333
Copy link
Contributor Author

/assign @pidb
request for a review

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@karmada-bot karmada-bot merged commit 5f16640 into karmada-io:master Aug 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants