-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response to priority change of PropagationPolicy #3965
Response to priority change of PropagationPolicy #3965
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3965 +/- ##
==========================================
- Coverage 54.66% 54.50% -0.16%
==========================================
Files 232 232
Lines 22521 22585 +64
==========================================
- Hits 12311 12310 -1
- Misses 9537 9602 +65
Partials 673 673
Flags with carried forward coverage won't be shown. Click here to find out more.
|
90898e2
to
60dfc68
Compare
and enqueue PropagationPolicy that could repreempte. Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
60dfc68
to
62a0e50
Compare
@wuyingjun-lucky Do you have any comments? I see you are looking at it :) |
// | ||
// The idea of the long-term solution, perhaps PropagationPolicy could have | ||
// a status, in that case we can record the observed priority(.status.observedPriority) | ||
// which can be used to detect priority changes during reconcile logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a good idea.
LGTM and I want have a try on “multiple preemption” |
No, you don't, haha, that's a chaotic state(but will stabilize eventually.) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR provides a temporary solution for corner case:
Which issue(s) this PR fixes:
Fixes #
Part of #3787
Special notes for your reviewer:
See #3684 (comment) for the background discussion.
In addition, this PR focuses on dealing with
PropagationPolicy
, if it is acceptable, theClusterPropagationPolicy
should do a similar thing.Test steps:
foo
with priority 5 andbar
with priority 4) as followsfoo
as it has higher priorityfoo
from5
to3
, then the Deployment should be preempted bybar
.meanwhile, I can see the relevant logs:
Does this PR introduce a user-facing change?: