Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for zones #3975

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add validation for zones #3975

merged 1 commit into from
Aug 25, 2023

Conversation

zishen
Copy link
Member

@zishen zishen commented Aug 22, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add validation for zones

Which issue(s) this PR fixes:
part of #3952

Special notes for your reviewer:

@XiShanYongYe-Chang @whitewindmills

Does this PR introduce a user-facing change?:

none

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 22, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3975 (f8f9314) into master (19fbab5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3975      +/-   ##
==========================================
+ Coverage   54.77%   54.82%   +0.04%     
==========================================
  Files         232      232              
  Lines       22529    22546      +17     
==========================================
+ Hits        12341    12361      +20     
+ Misses       9510     9508       -2     
+ Partials      678      677       -1     
Flag Coverage Δ
unittests 54.82% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/apis/cluster/validation/validation.go 79.86% <100.00%> (+5.05%) ⬆️

@whitewindmills
Copy link
Member

please don't write like this, it will cause this issue(#3952) to be closed following this PR.

Which issue(s) this PR fixes:
Fixes #3952

@whitewindmills
Copy link
Member

/assign

@zishen
Copy link
Member Author

zishen commented Aug 23, 2023

please don't write like this, it will cause this issue(#3952) to be closed following this PR.

Which issue(s) this PR fixes:
Fixes #3952

Ok, got it.

Signed-off-by: Tanggui Bian <softwarebtg@163.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@zishen Looks good to me, have you tested it?

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
Copy link
Member

@whitewindmills whitewindmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zishen
Copy link
Member Author

zishen commented Aug 25, 2023

/approve

@zishen Looks good to me, have you tested it?

yes, I had edit cluster, and add zone,zones. All met expectations.

image

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@karmada-bot karmada-bot merged commit 736ce11 into karmada-io:master Aug 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants