-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for zones #3975
Add validation for zones #3975
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3975 +/- ##
==========================================
+ Coverage 54.77% 54.82% +0.04%
==========================================
Files 232 232
Lines 22529 22546 +17
==========================================
+ Hits 12341 12361 +20
+ Misses 9510 9508 -2
+ Partials 678 677 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
please don't write like this, it will cause this issue(#3952) to be closed following this PR.
|
/assign |
Ok, got it. |
Signed-off-by: Tanggui Bian <softwarebtg@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@zishen Looks good to me, have you tested it?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yes, I had edit cluster, and add zone,zones. All met expectations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add validation for zones
Which issue(s) this PR fixes:
part of #3952
Special notes for your reviewer:
@XiShanYongYe-Chang @whitewindmills
Does this PR introduce a user-facing change?:
none