Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform zone to zones #3983

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

zishen
Copy link
Member

@zishen zishen commented Aug 23, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

transform zone to zones

Which issue(s) this PR fixes:
part of #3952

Special notes for your reviewer:

@XiShanYongYe-Chang @whitewindmills

Does this PR introduce a user-facing change?:

none

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 23, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 23, 2023
@zishen
Copy link
Member Author

zishen commented Aug 23, 2023

@whitewindmills @RainbowMango

I cleared the zones when I set them because they can't exist at the same time.

I am not sure whether this change is reasonable. Could you please confirm it according to the business?

@codecov-commenter
Copy link

Codecov Report

Merging #3983 (45c9d5e) into master (19fbab5) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3983      +/-   ##
==========================================
- Coverage   54.77%   54.77%   -0.01%     
==========================================
  Files         232      232              
  Lines       22529    22541      +12     
==========================================
+ Hits        12341    12347       +6     
- Misses       9510     9516       +6     
  Partials      678      678              
Flag Coverage Δ
unittests 54.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/apis/cluster/mutation/mutation.go 98.18% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

@whitewindmills
Copy link
Member

I am not sure whether this change is reasonable. Could you please confirm it according to the business?

I think it's okay.

@RainbowMango
Copy link
Member

I cleared the zones when I set them because they can't exist at the same time.

I guess you mean cleared the .spec.zone during migration.
Yes, I think we should do that.

Signed-off-by: Tanggui Bian <softwarebtg@163.com>
Copy link
Member

@whitewindmills whitewindmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@karmada-bot karmada-bot merged commit edcb431 into karmada-io:master Aug 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants