feat: adopt zones in scheduler spread by constraints

[zishen]

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

Adopt zones in scheduler spread by constraints.

Which issue(s) this PR fixes:
part of #3952

Special notes for your reviewer:

@RainbowMango @whitewindmills @huone1

Does this PR introduce a user-facing change?:

[zishen]

For zone is not supported in scheduler's spread constraint yet，I do not know how to test the zone selection schedule.

see the code here

func selectBestClustersBySpreadConstraints(spreadConstraints []policyv1alpha1.SpreadConstraint,
	groupClustersInfo *GroupClustersInfo, needReplicas int32) ([]*clusterv1alpha1.Cluster, error) {
	spreadConstraintMap := make(map[policyv1alpha1.SpreadFieldValue]policyv1alpha1.SpreadConstraint)
	for i := range spreadConstraints {
		spreadConstraintMap[spreadConstraints[i].SpreadByField] = spreadConstraints[i]
	}

	if _, exist := spreadConstraintMap[policyv1alpha1.SpreadByFieldRegion]; exist {
		return selectBestClustersByRegion(spreadConstraintMap, groupClustersInfo)
	} else if _, exist := spreadConstraintMap[policyv1alpha1.SpreadByFieldCluster]; exist {
		return selectBestClustersByCluster(spreadConstraintMap[policyv1alpha1.SpreadByFieldCluster], groupClustersInfo, needReplicas)
	} else {
		return nil, fmt.Errorf("just support cluster and region spread constraint")
	}
}

[codecov-commenter]

Codecov Report

Merging #4002 (10b5ff2) into master (fb4c16d) will increase coverage by 0.14%.
Report is 8 commits behind head on master.
The diff coverage is 91.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4002      +/-   ##
==========================================
+ Coverage   54.48%   54.62%   +0.14%     
==========================================
  Files         232      232              
  Lines       22685    22854     +169     
==========================================
+ Hits        12359    12485     +126     
- Misses       9649     9688      +39     
- Partials      677      681       +4     

Flag	Coverage Δ
unittests	54.62% <91.66%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
.../scheduler/core/spreadconstraint/group_clusters.go	90.47% <91.66%> (-4.73%)	⬇️

... and 6 files with indirect coverage changes

[whitewindmills]

The zone spread constraint is still dead code for now. So I think this PR is unnecessary.

[RainbowMango]

I get it, This PR just adopted the new zones, how about moving this forward and you can refactor it in #3662?

[whitewindmills]

how about moving this forward and you can refactor it in #3662?

these zone spread constraint codes have been deleted in #3662. 😂

[RainbowMango]

I agree that dead code should be removed.

This PR just removed the reference to deprecated code, that's the benefit we can get before #3662.
My opinion is moving this PR forward. What do you think @whitewindmills ?

[whitewindmills]

okay, just move it forward.

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment