Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add proposal for promote-dependencies-automatically #4100

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

zhy76
Copy link
Member

@zhy76 zhy76 commented Oct 6, 2023

What type of PR is this?
/kind feature
/kind documentation

What this PR does / why we need it:
Add proposal for promote-dependencies-automatically

Which issue(s) this PR fixes:
Part of #4036

Special notes for your reviewer:
none
Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/design Categorizes issue or PR as related to design. label Oct 6, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2023
@zhy76 zhy76 force-pushed the promote-dependency-proposal branch 3 times, most recently from 3e01fdc to 68b091c Compare October 6, 2023 15:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50b0c51) 52.76% compared to head (4b3d286) 52.79%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4100      +/-   ##
==========================================
+ Coverage   52.76%   52.79%   +0.02%     
==========================================
  Files         239      239              
  Lines       23584    23584              
==========================================
+ Hits        12445    12450       +5     
+ Misses      10462    10458       -4     
+ Partials      677      676       -1     
Flag Coverage Δ
unittests 52.79% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwcesign
Copy link
Member

jwcesign commented Oct 7, 2023

/assign

@zhy76 zhy76 force-pushed the promote-dependency-proposal branch from 68b091c to e0dc7e9 Compare October 9, 2023 08:04
@jwcesign
Copy link
Member

jwcesign commented Oct 9, 2023

/cc @XiShanYongYe-Chang for checking

@karmada-bot
Copy link
Collaborator

@jwcesign: GitHub didn't allow me to request PR reviews from the following users: for, checking.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @XiShanYongYe-Chang for checking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaunceyjiang
Copy link
Member

/assign

@jwcesign
Copy link
Member

Hi, @zhy76 Please add the behavior of meeting promoting failure(validation failed or other), and if part dependencies already exist, what should Karmada do?

@zhy76
Copy link
Member Author

zhy76 commented Oct 12, 2023

Thanks, I will refer to your suggestions~

@zhy76 zhy76 force-pushed the promote-dependency-proposal branch 2 times, most recently from 996c29f to 7b72b9e Compare October 13, 2023 07:44
Copy link
Member

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other lgtm

@jwcesign
Copy link
Member

Any more suggestions about port-forward? @chaunceyjiang

@jwcesign
Copy link
Member

/cc @chaunceyjiang

Do you have any more suggestions?

@zhy76
Copy link
Member Author

zhy76 commented Oct 26, 2023

Thanks for your suggestions, I will modify.

@jwcesign
Copy link
Member

/cc @XiShanYongYe-Chang

@zhy76 zhy76 closed this Nov 6, 2023
@zhy76 zhy76 force-pushed the promote-dependency-proposal branch from 6d0cc42 to 48b8e9f Compare November 6, 2023 08:54
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2023
@zhy76 zhy76 reopened this Nov 6, 2023
@karmada-bot karmada-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023
@zhy76
Copy link
Member Author

zhy76 commented Nov 6, 2023

/approve /批准 /hold /抓住 for setting the approvers and leave final decisions to 用于设置批准者并将最终决定权留给@jwcesign

added, thanks~

@jwcesign
Copy link
Member

jwcesign commented Nov 7, 2023

/approve

Thank you for your excellent work, @zhy76

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwcesign, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@RainbowMango
Copy link
Member

Pending — Not mergeable. Job e2e test has not succeeded.

I guess the robot missed the e2e test signal. I'll retrigger the tests again.

Signed-off-by: zhy76 <958474674@qq.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@RainbowMango
Copy link
Member

Pending — Not mergeable. Job e2e test has not succeeded.

I guess the robot missed the e2e test signal. I'll retrigger the tests again.

I'm not sure why the robot hanging there.
Just rebased this PR and try another time.

@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@zhy76
Copy link
Member Author

zhy76 commented Nov 8, 2023

Pending — Not mergeable. Job e2e test has not succeeded.

I guess the robot missed the e2e test signal. I'll retrigger the tests again.

I'm not sure why the robot hanging there. Just rebased this PR and try another time.

Thanks~

@karmada-bot karmada-bot merged commit 996d1a2 into karmada-io:master Nov 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants