-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support promote dependent resources automatically #4135
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4135 +/- ##
==========================================
- Coverage 52.78% 52.78% -0.01%
==========================================
Files 239 240 +1
Lines 23584 23624 +40
==========================================
+ Hits 12448 12469 +21
- Misses 10460 10475 +15
- Partials 676 680 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c25c09d
to
5781685
Compare
/assign |
8609c6b
to
c381775
Compare
when the PR is ready to review, please drop the |
8f9df5e
to
66f72d0
Compare
16f0163
to
fb4d917
Compare
Signed-off-by: zhy76 <958474674@qq.com>
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
@chaunceyjiang @yizhang-zen do you have any further comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work~
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #4036
Special notes for your reviewer:
WIP
Does this PR introduce a user-facing change?: