Fix: karmada-controller-manager: panic: runtime error: index out of range

[halfrost]

What type of PR is this?

What this PR does / why we need it:
Fix issue #3854
karmada-controller-manager: panic: runtime error: index out of range

Which issue(s) this PR fixes:
Fixes #3854

Special notes for your reviewer:

`karmada-controller-manager`: Fixed a panic issue due to `index out of range` in resource model functionality.

[RainbowMango]

Thanks @halfrost, appreciate it!

cc @tedli @liangyuanpeng @NickYadance @jwcesign @chaosi-zju help to take a look~ Thanks.

[jwcesign]

/lgtm

These two functions are not used:

karmada/pkg/modeling/modeling.go

Line 328 in 920f5bf

func (rs *ResourceSummary) UpdateInResourceSummary(oldNode, newNode ClusterResourceNode) error {

karmada/pkg/modeling/modeling.go

Line 274 in 920f5bf

func (rs *ResourceSummary) DeleteFromResourceSummary(crn ClusterResourceNode) error {

Can we delete them? @halfrost

[halfrost]

@jwcesign Hi, I have already removed these two functions that are currently not in use. This delete function took me some time to debug when it was initially developed. Now, they are no longer needed. Could you please review it again?

[jwcesign]

Can you help squash the multiple commits into one? other lgtm

cc @chaosi-zju for take another look

[halfrost]

@jwcesign Done

[chaosi-zju]

generally looks good to me

[chaosi-zju]

/lgtm

[jwcesign]

/cc @RainbowMango

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liangyuanpeng]

Sorry for my late and I have tried triggering ResourceSummary.getIndex continuously in an environment with 15 members of the cluster, but cannot reproduce the problem. I believe this PR can fix the problem.
/lgtm

[tedli]

Hi, @halfrost

It's this issue fixed by a single commit which asscoiated with this pr? Is there any other commits related?

I didn't use the latest release, I have a my own branch, I cherry-pick this commit, it builds, run, and works.

However, I run into another index out of range panic, so I thought whether my cherry pick lack some commits.

I1207 10:05:29.583572       7 controller.go:118] "Observed a panic in reconciler: runtime error: index out of range [2] with length 2" controller="cluster" controllerGroup="cluster.karmada.io" controllerKind="Cluster" Cluster="db-shbt" namespace="" name="db-shbt" reconcileID=5fff6af8-e7dc-4716-a6cf-34c4e9a6a0e5
panic: runtime error: index out of range [2] with length 2 [recovered]
	panic: runtime error: index out of range [2] with length 2

goroutine 1559 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	C:/Users/lizhen/Documents/Go/src/github.com/karmada-io/karmada/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:119 +0x1e5
panic({0x22b3fc0?, 0xc01306bc80?})
	C:/Program Files/Go/src/runtime/panic.go:914 +0x21f
github.com/karmada-io/karmada/pkg/modeling.(*ResourceSummary).getIndex(0xc00e7730a8, {0x2?, 0xc02121cf60?})
	C:/Users/lizhen/Documents/Go/src/github.com/karmada-io/karmada/pkg/modeling/modeling.go:125 +0x185
github.com/karmada-io/karmada/pkg/modeling.(*ResourceSummary).AddToResourceSummary(0xc00e7730a8, {0x1, 0xc02121cf60})
	C:/Users/lizhen/Documents/Go/src/github.com/karmada-io/karmada/pkg/modeling/modeling.go:181 +0x37
github.com/karmada-io/karmada/pkg/controllers/status.getAllocatableModelings(0xc02609e000, {0xc025e15800, 0x84, 0xc025e6d000?}, {0xc025e6d000, 0x532, 0x9f877eb7cc?})

func (rs *ResourceSummary) getIndex(crn ClusterResourceNode) int {
	index := math.MaxInt
	for i, m := range defaultModelSorting {
		tmpIndex := searchLastLessElement(rs.modelSortings[i], crn.resourceList[m])
		if tmpIndex < index {
			index = tmpIndex
		}
	}
	return index
}

[jwcesign]

Hi @tedli
Here is another PR: #4176

[tedli]

Hi @tedli Here is another PR: #4176

Thx 🥰