-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cluster flags for karmadactl top pod #4223
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4223 +/- ##
==========================================
- Coverage 52.83% 52.82% -0.01%
==========================================
Files 239 240 +1
Lines 23558 23595 +37
==========================================
+ Hits 12447 12465 +18
- Misses 10434 10454 +20
+ Partials 677 676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f09550e
to
2a21f82
Compare
7c88017
to
bdb1451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can you help add the corresponding e2e?
Thx~, I added the e2e task when decomposing tasks in the issue #4217 |
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
bdb1451
to
db09a25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work~
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@chaunceyjiang I'm surprised you are not on the approver list.
Now we lack approvers on CLI things, would you like to take the role?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes. ❤️ |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add cluster flags for karmadactl top pod
Which issue(s) this PR fixes:
Parts of #4217
Special notes for your reviewer:
Extracted some public methods for subsequent implementation of the
top node
commandAdd cluster flags to query the resource status of the cluster pod. Like
➜ karmada git:(top) ✗ karmadactl top po -Cmember1
NAME CLUSTER CPU(cores) MEMORY(bytes)
mycurlpods member1 0m 1Mi
Does this PR introduce a user-facing change?: