New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: enable lint of revive(superfluous-else) #4493
Cleanup: enable lint of revive(superfluous-else) #4493
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4493 +/- ##
==========================================
- Coverage 51.87% 51.85% -0.02%
==========================================
Files 243 243
Lines 24181 24181
==========================================
- Hits 12543 12540 -3
- Misses 10957 10959 +2
- Partials 681 682 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @RainbowMango
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#superfluous-else
Description: To improve the readability of code, it is recommended to reduce the indentation as much as possible. This rule highlights redundant else-blocks that can be eliminated from the code.
I like this rule.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Enable lint of revive(superfluous-else)
Which issue(s) this PR fixes:
Partof #4490
Special notes for your reviewer:
Does this PR introduce a user-facing change?: