Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: enable revive(blank-imports/indent-error-flow rule) checking #4495

Merged
merged 1 commit into from Jan 10, 2024
Merged

cleanup: enable revive(blank-imports/indent-error-flow rule) checking #4495

merged 1 commit into from Jan 10, 2024

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Jan 2, 2024 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
cleanup: enable revive(blank-imports/indent-error-flow rule) checking

Which issue(s) this PR fixes:
Part of #4490

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (43c3e33) 51.86% compared to head (e36a80c) 51.86%.

Files Patch % Lines
pkg/webhook/cronfederatedhpa/validating.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4495   +/-   ##
=======================================
  Coverage   51.86%   51.86%           
=======================================
  Files         243      243           
  Lines       24184    24183    -1     
=======================================
+ Hits        12542    12543    +1     
+ Misses      10960    10959    -1     
+ Partials      682      681    -1
Flag Coverage Δ
unittests 51.86% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwcesign jwcesign mentioned this pull request Jan 2, 2024
Closed
23 tasks
@RainbowMango
Copy link
Member

You might need to resolve the conflict.

@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2024
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2024
@jwcesign jwcesign changed the title cleanup: enable revive(blank-imports rule) checking cleanup: enable revive(blank-imports/indent-error-flow rule) checking Jan 9, 2024
@jwcesign jwcesign mentioned this pull request Jan 9, 2024
Closed
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@RainbowMango
Copy link
Member

Don't know why the test was not triggered, I can't help, you might need to retry by another push.

@jwcesign
cleanup: enable revive(blank-imports rule) checking
e36a80c 
Signed-off-by: jwcesign <jwcesign@gmail.com>
@jwcesign
Copy link
Member Author

/cc @RainbowMango
CI passed

RainbowMango
RainbowMango approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/webhook/cronfederatedhpa/validating.go

"github.com/adhocore/gronx"
apimachineryvalidation "k8s.io/apimachinery/pkg/api/validation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@karmada-bot karmada-bot merged commit bef4e7a into karmada-io:master Jan 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

Assignees

@RainbowMango RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jwcesign @codecov-commenter @RainbowMango @karmada-bot @XiShanYongYe-Chang