Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add e2e coverage detail(last part) #4521

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?
/kind documentation
add e2e coverage details(last part)

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #3685

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 6, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2024
@Vacant2333 Vacant2333 changed the title docs: Add e2e coverage detail docs: Add e2e coverage detail(last part) Jan 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (303f2cd) 51.87% compared to head (5110ce0) 51.86%.
Report is 67 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4521      +/-   ##
==========================================
- Coverage   51.87%   51.86%   -0.02%     
==========================================
  Files         243      243              
  Lines       24181    24183       +2     
==========================================
- Hits        12545    12543       -2     
- Misses      10955    10959       +4     
  Partials      681      681              
Flag Coverage Δ
unittests 51.86% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Hi @Vacant2333 is it ready to review?

@Vacant2333
Copy link
Contributor Author

Hi @Vacant2333 is it ready to review?

yes~

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/assign

@Vacant2333
Copy link
Contributor Author

Thanks~ /assign

search_test.go is a bit messy and may need to be sorted out. For example, from the analysis document, we can see that a lot of ginkgo.it contents are very irregular.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

test/e2e/scheduling_test.go Outdated Show resolved Hide resolved
Signed-off-by: Vacant <vacant@MasterNode.local>
Signed-off-by: Vacant <vacant@192.168.0.107>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

As I comment in #4536 (comment), we can add a script to automatically generate test coverage record documents.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2024
@karmada-bot karmada-bot merged commit be5b5a8 into karmada-io:master Jan 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants