-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add e2e coverage detail(last part) #4521
docs: Add e2e coverage detail(last part) #4521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4521 +/- ##
==========================================
- Coverage 51.87% 51.86% -0.02%
==========================================
Files 243 243
Lines 24181 24183 +2
==========================================
- Hits 12545 12543 -2
- Misses 10955 10959 +4
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @Vacant2333 is it ready to review? |
yes~ |
Thanks~ |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
71a7d9c
to
aa821b6
Compare
Signed-off-by: Vacant <vacant@MasterNode.local> Signed-off-by: Vacant <vacant@192.168.0.107>
aa821b6
to
5110ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
As I comment in #4536 (comment), we can add a script to automatically generate test coverage record documents.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
add e2e coverage details(last part)
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #3685